Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent checktx #788

Closed
4 tasks done
dudong2 opened this issue Nov 8, 2022 · 1 comment
Closed
4 tasks done

concurrent checktx #788

dudong2 opened this issue Nov 8, 2022 · 1 comment
Assignees
Labels
A: improvement Changes in existing functionality

Comments

@dudong2
Copy link
Contributor

dudong2 commented Nov 8, 2022

Summary

From #141, concurrent checktx implemented.
This logic is not managed and it is different from the structure of cosmos-sdk, so when bumping up, problems occur in a many parts.
Performance measurement is required for this.
We should consider reverting to the cosmos-sdk's way if we no longer see any performance gains.

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dudong2 dudong2 added the A: improvement Changes in existing functionality label Nov 8, 2022
@dudong2 dudong2 self-assigned this Nov 21, 2022
@dudong2
Copy link
Contributor Author

dudong2 commented Dec 5, 2022

  • cosmos-sdk style tx processing flow

스크린샷 2022-12-05 오전 10 33 17

  • lbm-sdk style tx processing flow

스크린샷 2022-12-05 오전 10 33 40

As a result of simple performance measurement, 1039 tps came out in cosmos-sdk style and 1704 tps came out in lbm-sdk style. We can see that processing CheckTx and RecheckTx concurrently has a great increase on performance. So, instead of rolling it back to cosmos-sdk style, we need to find a way to keep it well maintained and improve it even more.

@dudong2 dudong2 closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant