Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the deprecate comment and warning usage in BroadcastMode Block #902

Closed
4 tasks
zemyblue opened this issue Feb 16, 2023 · 1 comment · Fixed by #923
Closed
4 tasks

Add the deprecate comment and warning usage in BroadcastMode Block #902

zemyblue opened this issue Feb 16, 2023 · 1 comment · Fixed by #923
Assignees
Labels
good first issue Good for newcomers

Comments

@zemyblue
Copy link
Member

zemyblue commented Feb 16, 2023

Summary

Add deprecated comments and warning usage at all points where BroadcastMode block is used.

Problem Definition

BroadcastMode Block was developed for debug as far as I know, but I think this mode is used because of it is very convenience in client side. But block mode has many problem like blocking mempool checkTx and etc. Therefore it need to be removed. But I don't know which problem is occurred if we remove it. And it'll be remove in the cosmos-sdk v0.47. (cosmos/cosmos-sdk#12167) Therefore I think it's better to add deprecated comment and warning usaged.

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue zemyblue added the good first issue Good for newcomers label Feb 16, 2023
@thiyagarajan17
Copy link

would love to take a look.. assign issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants