Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to replace tendermint/tendermint to cometbft/cometbft #556

Open
2 of 4 tasks
tkxkd0159 opened this issue Feb 2, 2023 · 3 comments
Open
2 of 4 tasks

Need to replace tendermint/tendermint to cometbft/cometbft #556

tkxkd0159 opened this issue Feb 2, 2023 · 3 comments
Assignees
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code C: proposal Classification: Proposal for specification, algorithm, architecture, or communication Stale For github bot

Comments

@tkxkd0159
Copy link
Member

tkxkd0159 commented Feb 2, 2023

Summary

ref. tendermint/tendermint#9972

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tkxkd0159 tkxkd0159 added the C: discussion Classification: Discuss something label Feb 2, 2023
@tkxkd0159 tkxkd0159 changed the title Need to replace tendermint/tendermint to informalsystems/tendermint Need to replace tendermint/tendermint to cometbft/cometbft Feb 2, 2023
@torao
Copy link
Contributor

torao commented Feb 3, 2023

There has been an official announcement to switch from Tendermint Core to CometBFT. This includes changes to Tendermint peripheral modules, such as tm-dbcometbft-db. Future Ostracon should also consider plans to change its codebase to CometBFT.
https://github.com/cometbft/cometbft
https://medium.com/the-interchain-foundation/cosmos-meet-cometbft-d89f5dce60dd

This task may be tracked after the current project phase.

@tnasu
Copy link
Member

tnasu commented Feb 3, 2023

@tkxkd0159
What are the discussion points? I think we should follow cometbft/cometbft as well. Basically, we forked/followed-up the based on tendermint-v0.34.19. It means the compatibility between cometbft and ostracon.
It's possible to replace the below:

  • Replace tendermint/tendermint to cometbft/cometbft in go.mod
  • Replace tendermint/tm-db to cometbft/cometbft-db in go.mod

@github-actions github-actions bot added the Stale For github bot label Feb 14, 2023
@tkxkd0159
Copy link
Member Author

@tnasu Sorry I missed this alarm. I just evoked the surroundings to make this change. So there is no point in discussion.

@tkxkd0159 tkxkd0159 added C: enhancement Classification: New feature or its request, or improvement in maintainability of code C: proposal Classification: Proposal for specification, algorithm, architecture, or communication and removed C: discussion Classification: Discuss something Stale For github bot labels Feb 15, 2023
@github-actions github-actions bot added the Stale For github bot label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code C: proposal Classification: Proposal for specification, algorithm, architecture, or communication Stale For github bot
Projects
None yet
Development

No branches or pull requests

3 participants