Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose methods to completely separate the functions of dynamic_link into wasmplus #23

Closed
da1suk8 opened this issue Apr 6, 2023 · 1 comment
Assignees

Comments

@da1suk8
Copy link
Member

da1suk8 commented Apr 6, 2023

At present #22, only partial separation has been made for dynamic link branch of wasmd, so consider how to do this.


The following methods were used for implementation.

In #36, moved dynamic_link branch functionality to wasmplus.

It is implemented in the following way.

  1. Define the interface of the function defined in x/wasmplus/keeper.go in x/wasm/keeper.go.
  2. In x/wasm, functions and variables to be exposed to the outside world are defined as other variables in exported_*.go, in order to reduce differences from the original.
  3. Access the functions defined in x/wasmplus/api.go via the interface in x/wasm/keeper.go.
@da1suk8
Copy link
Member Author

da1suk8 commented Apr 27, 2023

Closed via #36

@da1suk8 da1suk8 closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant