Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer 3.0 support #261

Open
kroupacz opened this issue Aug 23, 2017 · 17 comments
Open

Polymer 3.0 support #261

kroupacz opened this issue Aug 23, 2017 · 17 comments

Comments

@kroupacz
Copy link

Hello,
Is there an estimated time when we could expect a new version of polymerfire which will be built according to the new Polymer 3.0 standard and stored in NPM?

@tjmonsi
Copy link
Collaborator

tjmonsi commented Sep 2, 2017

I would like to try creating a PR over the week and see if it is going to be merged.

@tjmonsi
Copy link
Collaborator

tjmonsi commented Sep 9, 2017

Oh wait... it uses some sort of builder. I think the Polymer team has that builder that auto-updates it to Polymer 3.0 standards...

@TimvdLippe
Copy link

This element will be auto-upgraded once the modulizer is more robust.

@jukbot
Copy link

jukbot commented Nov 14, 2017

Hi, when polymerfire will publish to npm ?

@Mash19
Copy link

Mash19 commented Nov 15, 2017

I took a look at this trying to modify and ran into issues. The modulizer didn't transform the hybrid polymer elements so the code would need to be updated to the class syntax for modulizer. However after conversion I had an issue importing the firebase code. It's using a global variable (firebase) which works fine for HTML imports but with modules that value wasn't being pulled in with imports. The firebase code isn't exporting anything for ES2015 modules to use. Without a build tool I wasn't sure how to proceed from there especially in regards to using only specific components.

@tjmonsi
Copy link
Collaborator

tjmonsi commented Feb 21, 2018

Although I would love to just use the modulizer. I have to review the whole code (and might do a re-write of some parts). Given that the modulizer is still in its alpha-stage, and have some problems... I don't have a better idea on what's the best alternative.

I also want to think if it is possible to rewrite the behaviors to mixins and add a Firestore behavior for backwards compat.

@davie-robertson
Copy link

Any update on this folks? Not long until the end of Q1 (aka 3.0 launch).

Does the current build work in a 3.0 project?

@zevdg
Copy link

zevdg commented May 10, 2018

Polymer 3.0 has officially launched now.

Unfortunately, the modulizer still isn't "finished", but it's far enough along that they encourage people to try using it on their codebase. The expectation is that either

  • it works for your code base
  • it gets you most of the way there and you can do the rest by hand

or in the worst case

  • finds bugs or edge cases that can be reported upstream.

Has anyone attempted the conversion since @Mash19 in November? It seems like a good time to give it another shot, and if it still doesn't work, report issues upstream.

@merlinnot
Copy link
Contributor

We should probably just make a PR. I made a WIP PR (#344) against firestore branch since it is the most important part for me.

Can we split the work somehow?

@adueppen
Copy link

@zevdg I just tried running the modulizer on the project and it produced the same thing (as far as I can tell) as what @Mash19 reported. It converts the imports, but not the Polymer(); call.

@merlinnot
Copy link
Contributor

Modulizer won't do everything for us. It just requires some manual work to make it Polymer 3 - compatible.

@cwichoski
Copy link

Hi

I'm new to polymer, and planning to use in a new project and that will use firebase too, on reasearch I found this issue, any thing to worry? or its ok to use Firebase Javascript SDK until you got back polymerfire working? or for now better use version 2.0 then migrate to 3.0 when all things are solved for last version?

@BrandiATMuhkuh
Copy link

BrandiATMuhkuh commented May 31, 2018

@cwichoski If you start a new project with polymer 3, it's probably simpler to use the normale firebase SDK instead of polymerfire. Since the developer experience of Polymer 3 (with LitElement) and React are now practically identical, I would have a look at React + Firebase documentation.

@intcreator
Copy link

@Mash19 @merlinnot have you guys had any luck with this?

@merlinnot
Copy link
Contributor

That's the current status: @intcreator #353

@mmikrut
Copy link

mmikrut commented Mar 5, 2019

Try https://github.com/iceflow19/polymerfire
works for me, including geofire

@LeongTitanFour
Copy link

https://www.npmjs.com/package/polymerfire3
Hope it helps you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests