Implementing INT128 (FB 4.0 feature)

[MartinKoeditz]

I struggle with the new INT128 datatype. PHP supports 64 bit. For the INT128 I wanted to use (output) it as a string. But currently I'm unable to use the correct Firebird API / ISC.

Any help is welcome.

[AlexPeshkoff]

On 3/26/24 19:05, Martin Köditz wrote: I struggle with the new INT128 datatype. PHP supports 64 bit. For the INT128 I wanted to use (output) it as a string. But currently I'm unable to use the correct Firebird API / ISC. Any help is welcome.

There are 2 ways to solve a problem: - use dedicated interface     class IInt128     {         virtual void toString(StatusType* status, const FB_I128* from, int scale, unsigned bufferLength, char* buffer) = 0;         virtual void fromString(StatusType* status, int scale, const char* from, FB_I128* to) = 0;     }; // for details see doc/Using_OO_API.html - cast values, the simplest way for it is to ask server to change int128 values to strings     set bind of int128 to varchar;   (this is SQL form), preferred for you way is to use DPB, tag isc_dpb_set_bind, string value "int128 to varchar".

[mlazdans]

Do we need handling 128-bit integers at the extension level? PHP do not have native 128-bit integer type so these values will appear to users as strings anyway. isc_dpb_set_bind tag sounds like a fast to implement and simple solution.

[AlexPeshkoff]

I'm not PHP professional - but be sure, isc_dpb_set_bind was added exactly for such cases.

[mlazdans]

@MartinKoeditz any thoughts?

[mlazdans]

I roughly implemented these new FB types: INT128, DECFLOAT, TIME WITH TIMEZONE, TIMESTAMP WITH TIMEZONE.

Check it out in types5.0 branch in my fork: https://github.com/mlazdans/php-firebird/tree/types5.0

Windows DLL's: https://github.com/mlazdans/php-firebird/releases/tag/v3.0.1-d1723b6

[MartinKoeditz]

Merged your code recently. I will add revisions etc. this weekend.

[mlazdans]

Great. Needs to be tested on different PHP/FB versions. I've developed using PHP 8.4 nts + Firebird 5 libraries.

[MartinKoeditz]

No problems yet. I will implement some Tests for the new implemented data types.