Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of buttons? #122

Closed
vanillajonathan opened this issue Oct 23, 2017 · 2 comments
Closed

Size of buttons? #122

vanillajonathan opened this issue Oct 23, 2017 · 2 comments
Assignees
Milestone

Comments

@vanillajonathan
Copy link

What exactly does the "size" property refer to in the context of buttons?
Is it font-size?
It is rather ambiguous as to what it means.

Property Value
Height 32px
Padding 8px
Size 13px

If size refers to font-size and padding is 8 pixel on the top and 8 pixel on the bottom then that would be 8 + 13 + 8 which equals 29 which does not add up to the declared height of 32 pixels.

This leaves me confused.

@brassy-
Copy link
Collaborator

brassy- commented Oct 26, 2017

A text with a 13px font-size is not equal to 13px computed.
The height of the button is hard-coded.

(a codepen is coming ;) )

@aminalhazwani
Copy link
Contributor

Here is an early codepen we used for testing WCGA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants