Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons component: Define & Document #196

Closed
designakt opened this issue Nov 21, 2017 · 7 comments
Closed

Radio buttons component: Define & Document #196

designakt opened this issue Nov 21, 2017 · 7 comments

Comments

@designakt
Copy link
Member

The component is built in sketch, now we need to define it's functionality and design to document it.

@tinahsieh
Copy link

tinahsieh commented Nov 27, 2017

screen shot 2017-11-27 at 4 43 15 pm

Can not really understand what it means...can we add some specs on the image? or we move the focused state details to the patterns.

screen shot 2017-11-27 at 4 52 19 pm

This paragraph doesn't seem like a style to me...More like a "Variants" :)

@TLHuang
Copy link
Contributor

TLHuang commented Nov 27, 2017

Just found the zooming style is different with the one you create for Checkboxes, is it intended?
screen shot 2017-11-27 at 4 49 28 pm

@designakt
Copy link
Member Author

@tinahsieh I agree, for the focus-state we need a better way to communicate it:
This seams bigger then just Radio Buttons, so I created an issue for us to discuss.

@designakt
Copy link
Member Author

This paragraph doesn't seem like a style to me...More like a "Variants" :)

@tinahsieh I am not sure I understand where you see variants... is it the selected/unselected part? Could you elaborate on that? To me that section is to show the individual parts of a radio button that have to be styled.

@aminalhazwani
Copy link
Contributor

hey @designakt I noticed that on staging the shape of the focused radio buttons seem off.

screenshot-2017-11-27 photon design system

@aminalhazwani
Copy link
Contributor

aminalhazwani commented Nov 27, 2017

hey @designakt jfyi if you need to add a small text with a dos/donts we could do it similarly as the inactive pattern.

screenshot-2017-11-27 photon design system 1

@designakt
Copy link
Member Author

Fixed the focus problem, and used the do/don't description amin suggested. - makes it easier to read. thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants