Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component card: build #232

Closed
3 tasks done
tinahsieh opened this issue Jan 8, 2018 · 3 comments
Closed
3 tasks done

Component card: build #232

tinahsieh opened this issue Jan 8, 2018 · 3 comments
Assignees
@tinahsieh
Milestone
v0.6.4

Comments

@tinahsieh
Copy link

tinahsieh commented Jan 8, 2018 •
edited
Loading

  • Design a card with unified radius, margin, and shadow.
  • Test the card on projects and see how it works.
  • Sync with project owners and do some iterations if needed
@tinahsieh tinahsieh self-assigned this Jan 8, 2018
@aminalhazwani aminalhazwani added this to the 2018.01.15 milestone Jan 9, 2018
@tinahsieh
Copy link
Author

It's very hard to tell the difference between 3px and 4px corner, so I assume that designers who are using 3px will be OK with the new guideline.

I'll talk to Philip—AMO with 9px corner radius about the new design guide (including radius, shadow, and margin) to see how he think about it.

@tinahsieh
Copy link
Author

Just talked to Carol for Fennec and she is currently using 4px as corner radius, yay!

@tinahsieh
Copy link
Author

Checked with AMO.

@aminalhazwani aminalhazwani mentioned this issue Jan 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinahsieh tinahsieh

Labels
None yet
Projects
None yet
Milestone
v0.6.4
Development

No branches or pull requests
2 participants
@aminalhazwani @tinahsieh