Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro buttons are tough to read as-is (without text shadow) #264

Closed
tofumatt opened this issue Jan 30, 2018 · 2 comments
Closed

Micro buttons are tough to read as-is (without text shadow) #264

tofumatt opened this issue Jan 30, 2018 · 2 comments
Assignees
Milestone

Comments

@tofumatt
Copy link

I find the small button size tough to see (almost a bit blurry). Here is the button in use on the Add-ons site:

screenshot 2018-01-30 19 36 05

screenshot 2018-01-30 19 36 32

I found adding some text-shadow, just to the small button, really improves readability:

screenshot 2018-01-30 19 36 12

screenshot 2018-01-30 19 36 32

@aminalhazwani aminalhazwani added this to the v0.6.7 milestone Feb 6, 2018
@aminalhazwani
Copy link
Contributor

Hey @tofumatt I cannot tell from the screenshot what's the hex code that you're using for the micro button. If you're using blue 60 #0060df for the default state, blue 70 #003eaa for hover and blue 80 #002275 for active/pressed it should be well contrasted!

The main issue I see is that Fira Sans doesn't perform very well at small sizes (11px in this example), especially with the font weight set to normal 400. So, while we figure out what to do with Fira Sans you could try to increase either increase the letter spacing (eg letter-spacing: 0.01rem) or to set the font weight light 300.

@aminalhazwani
Copy link
Contributor

We see this issue as fixed. CC @pwalm to follow up with engineering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants