Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary Button Styles #97

Closed
aaronrbenson opened this issue Sep 28, 2017 · 4 comments
Closed

Secondary Button Styles #97

aaronrbenson opened this issue Sep 28, 2017 · 4 comments

Comments

@aaronrbenson
Copy link
Collaborator

Working on adding a secondary button style with default, hover and active states. The draft styles are pretty dark to begin with.

We settled on the following which looks 👌🏼. Thoughts @aminalhazwani @brassy- ?

screen shot 2017-09-28 at 3 22 49 pm

@aminalhazwani
Copy link
Contributor

Yeah, it is also particularly challenging to design secondary buttons that do not look disable 😅 Are these three different proposals or hover/active states? It would be also interesting to pair a primary with a secondary in order to see how the two look together (the primary w/o border and the secondary with border).

@brassy-
Copy link
Collaborator

brassy- commented Sep 28, 2017

I second Amin to try to pair the primary with the secondary.

I think can explore the idea to have the secondary button looking different only in the default mode, but share the stye with the primary for hover and active.

Bonus question: what we can learn and maybe re-use from existing elements? I'm thinking of the 'ghost'/'icon' button in the toolbar. ;)

@aaronrbenson
Copy link
Collaborator Author

These are the three states, not variations.

@aaronrbenson
Copy link
Collaborator Author

I’m bothered a little that a different color value is used for the default and then the two states (hover and active). Maybe we shouldn’t use semi-opaque values either in cases where these aren’t against an all-white background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants