Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionUrlHandling does not have a value for "do nothing" #225

Open
ewoutkramer opened this issue Dec 11, 2023 · 1 comment
Open

ExtensionUrlHandling does not have a value for "do nothing" #225

ewoutkramer opened this issue Dec 11, 2023 · 1 comment

Comments

@ewoutkramer
Copy link
Member

ExtensionUrlHandling currently looks like this:

public enum ExtensionUrlHandling
{
    //
    // Summary:
    //     Do not resolve the extension
    DontResolve,
    //
    // Summary:
    //     Add a warning to the validation result when the extension cannot be resolved
    WarnIfMissing,
    //
    // Summary:
    //     Add an error to the validation result when the extension cannot be resolved
    ErrorIfMissing
}

When an extension is missing we only have the ability to raise an error or warning, or not validate the extension at all (which really means: validate against Extension, so it must still be there). There is no way to say: totally ignore this extension, and I think there's a clear usecase for that.

@ewoutkramer ewoutkramer changed the title ExtensionUrlHandling does not have a value for "nothing" ExtensionUrlHandling does not have a value for "do nothing" Dec 11, 2023
@ewoutkramer
Copy link
Member Author

Guess that's an easy extra option, though we should more clearly document what the difference is with DontResolve, as I don't even understand that 100% now. But given my comment above, there's supposed to be a difference ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants