TIKA-3649 fixes for static analysis report of module tika-translate (apache#486)

* TIKA-3649 fixes for static analysis report of module tika-translate

* TIKA-3649 POM section for static analysis in the module tika-translate

Co-authored-by: dk2k <dk2k@ya.ru>

Author: dk2k

tika-translate/pom.xml

@@ -187,6 +187,35 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-site-plugin</artifactId>
+        <version>3.4</version>
+        <configuration>
+          <reportPlugins>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-project-info-reports-plugin</artifactId>
+              <version>2.8</version>
+              <reports>
+                <report>index</report>
+              </reports>
+            </plugin>
+            <plugin>
+              <groupId>org.codehaus.mojo</groupId>
+              <artifactId>findbugs-maven-plugin</artifactId>
+              <version>3.0.5</version>
+              <configuration>
+                <argLine>-Xmx256m</argLine>
+                <argLine>-XX:MaxPermSize=256m</argLine>
+                <timeout>240000</timeout>
+                <effort>max</effort>
+                <failOnError>true</failOnError>
+              </configuration>
+            </plugin>
+          </reportPlugins>
+        </configuration>
+      </plugin>
     </plugins>
 
     <pluginManagement>
@@ -217,6 +246,7 @@
             </lifecycleMappingMetadata>
           </configuration>
         </plugin>
+
       </plugins>
     </pluginManagement>
   </build>

tika-translate/src/main/java/org/apache/tika/language/translate/impl/GoogleTranslator.java

@@ -84,12 +84,16 @@ public String translate(String text, String sourceLanguage,
         Response response = client.accept(MediaType.APPLICATION_JSON)
                 .query("key", apiKey).query("source", sourceLanguage)
                 .query("target", targetLanguage).query("q", text).get();
-        BufferedReader reader = new BufferedReader(new InputStreamReader(
-                (InputStream) response.getEntity(), UTF_8));
-        String line = null;
-        StringBuffer responseText = new StringBuffer();
-        while ((line = reader.readLine()) != null) {
-            responseText.append(line);
+
+        StringBuilder responseText = new StringBuilder();
+        try (InputStreamReader inputStreamReader = new InputStreamReader(
+                (InputStream) response.getEntity(), UTF_8);
+            BufferedReader reader = new BufferedReader(inputStreamReader);
+        ) {
+            String line;
+            while ((line = reader.readLine()) != null) {
+                responseText.append(line);
+            }
         }
 
         ObjectMapper mapper = new ObjectMapper();

tika-translate/src/main/java/org/apache/tika/language/translate/impl/JoshuaNetworkTranslator.java

@@ -148,14 +148,17 @@ public String translate(String text, String sourceLanguage,
     ObjectNode jsonNode = requestMapper.createObjectNode();
     jsonNode.put("inputLanguage", sourceLanguage);
     jsonNode.put("inputText", inputText);
-    //make the reuest
+    //make the request
     Response response = client.accept(MediaType.APPLICATION_JSON).type(MediaType.APPLICATION_JSON).post(jsonNode);
-    BufferedReader reader = new BufferedReader(new InputStreamReader(
-        (InputStream) response.getEntity(), UTF_8));
-    String line;
     StringBuilder responseText = new StringBuilder();
-    while ((line = reader.readLine()) != null) {
-      responseText.append(line);
+    try (InputStreamReader inputStreamReader = new InputStreamReader(
+            (InputStream) response.getEntity(), UTF_8);
+         BufferedReader reader = new BufferedReader(inputStreamReader);
+    ) {
+      String line;
+      while ((line = reader.readLine()) != null) {
+        responseText.append(line);
+      }
     }
 
     try {

tika-translate/src/main/java/org/apache/tika/language/translate/impl/Lingo24Translator.java

@@ -81,12 +81,15 @@ public String translate(String text, String sourceLanguage,
         Response response = client.accept(MediaType.APPLICATION_JSON)
                 .query("user_key", userKey).query("source", sourceLanguage)
                 .query("target", targetLanguage).query("q", text).get();
-        BufferedReader reader = new BufferedReader(new InputStreamReader(
-                (InputStream) response.getEntity(), UTF_8));
-        String line = null;
-        StringBuffer responseText = new StringBuffer();
-        while ((line = reader.readLine()) != null) {
-            responseText.append(line);
+        StringBuilder responseText = new StringBuilder();
+        try (InputStreamReader inputStreamReader = new InputStreamReader(
+                (InputStream) response.getEntity(), UTF_8);
+             BufferedReader reader = new BufferedReader(inputStreamReader);
+        ) {
+            String line;
+            while ((line = reader.readLine()) != null) {
+                responseText.append(line);
+            }
         }
 
         ObjectMapper mapper = new ObjectMapper();

tika-translate/src/main/java/org/apache/tika/language/translate/impl/YandexTranslator.java

@@ -103,12 +103,15 @@ public String translate(String text, String sourceLanguage,
         Response response = client.accept(MediaType.APPLICATION_JSON)
                 .query("key", this.apiKey).query("lang", langCode)
                 .query("text", text).get();
-        BufferedReader reader = new BufferedReader(new InputStreamReader(
-                (InputStream) response.getEntity(), UTF_8));
-        String line = null;
-        StringBuffer responseText = new StringBuffer();
-        while ((line = reader.readLine()) != null) {
-            responseText.append(line);
+        StringBuilder responseText = new StringBuilder();
+        try (InputStreamReader inputStreamReader = new InputStreamReader(
+                (InputStream) response.getEntity(), UTF_8);
+             BufferedReader reader = new BufferedReader(inputStreamReader);
+        ) {
+            String line;
+            while ((line = reader.readLine()) != null) {
+                responseText.append(line);
+            }
         }
 
         try {