Skip to content
This repository has been archived by the owner on Feb 17, 2022. It is now read-only.

Security review #2 issues #7

Closed
miohtama opened this issue Sep 24, 2016 · 1 comment
Closed

Security review #2 issues #7

miohtama opened this issue Sep 24, 2016 · 1 comment

Comments

@miohtama
Copy link
Contributor

  • Multisig wallet and execute() - remove daily limit functionality. We want multisig to contract call execute() operations with zero value, as these can be operations like change founder.
  • Left padding zeroes in web3 call conventions - web3 left-aligns values when passed to bytes32 argument. web3/web3.js#431 - 50% chance to fail deposit on crowdfunding page
  • Metamask and sale page UI needs polish - too confusing for end users
@JasonMcz
Copy link
Contributor

Left padding zeroes in web3 call conventions - web3/web3.js#431 - 50% chance to fail deposit on crowdfunding page.

Resolved by making a change on the front-end parsing the value.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants