-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injection in Brave Search broken after page redesign #22
Comments
Thank you, I can reproduce the issue. Brave Search completely redesigned their search page and got rid of the sidebar that I used to put the results in. They switched to a mobile-first design with only a single column it seems. There's two ways to solve this. I personally don't use Brave Search, so I would kindly ask you @schossel to tell me what you as a user would prefer. @YMan84 you originally requested support for Brave Search, maybe you want to pitch in? Anyway, here are the two options. Please keep in mind these are quick and dirty mockups, the actual boxes would conform closer to the page design: 2. put the injection box in the main column, pushing down secondary results. For this option there would also be the question of where to inject (right at the top, above News, below News) |
If it's not too much trouble I would prefer Nr 1. |
On further inspection Brave Search did indeed keep the sidebar. I will put it there then. |
If it works, I'm the last to complain. |
Should be fixed in v1.3.3. It's already available on firefox, the chrome web store will receive it probably within the next 24 hours. If the issue persists, please reopen this issue. |
1.3.3 seems to work. Thanks! |
@Fivefold Thanks for the fix! |
I can't get the extension to work anymore in Brave. It connects to linkding but doesn't inject any results into the Brave results. If I use google as search engine they are injected as intended.
The text was updated successfully, but these errors were encountered: