Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injection in Brave Search broken after page redesign #22

Closed
schossel opened this issue Sep 27, 2023 · 7 comments
Closed

Injection in Brave Search broken after page redesign #22

schossel opened this issue Sep 27, 2023 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@schossel
Copy link

I can't get the extension to work anymore in Brave. It connects to linkding but doesn't inject any results into the Brave results. If I use google as search engine they are injected as intended.

@Fivefold
Copy link
Owner

Fivefold commented Sep 27, 2023

Thank you, I can reproduce the issue. Brave Search completely redesigned their search page and got rid of the sidebar that I used to put the results in. They switched to a mobile-first design with only a single column it seems.

There's two ways to solve this. I personally don't use Brave Search, so I would kindly ask you @schossel to tell me what you as a user would prefer.

@YMan84 you originally requested support for Brave Search, maybe you want to pitch in?
@Sevichecc I believe you use SearX but you at least worked on Brave Search as well. Maybe you have thoughts on this, too.

Anyway, here are the two options. Please keep in mind these are quick and dirty mockups, the actual boxes would conform closer to the page design:
1. create my own sidebar and put the injection box there. This will be the only sidebar content, since all regular content is in the main column in this new design:

image

2. put the injection box in the main column, pushing down secondary results. For this option there would also be the question of where to inject (right at the top, above News, below News)

image

@Fivefold Fivefold changed the title Injection in Brave Browser not working anymore Injection in Brave Search broken after page redesign Sep 27, 2023
@Fivefold Fivefold added bug Something isn't working help wanted Extra attention is needed labels Sep 27, 2023
@schossel
Copy link
Author

If it's not too much trouble I would prefer Nr 1.

@Fivefold
Copy link
Owner

On further inspection Brave Search did indeed keep the sidebar. I will put it there then.

@schossel
Copy link
Author

If it works, I'm the last to complain.

@Fivefold
Copy link
Owner

Should be fixed in v1.3.3. It's already available on firefox, the chrome web store will receive it probably within the next 24 hours. If the issue persists, please reopen this issue.

@schossel
Copy link
Author

1.3.3 seems to work. Thanks!

@Sevichecc
Copy link
Contributor

Sevichecc commented Oct 31, 2023

@Fivefold Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants