Too many end-to-end-tests

[cafca]

What's the problem you want solved?

Too many end-to-end tests means having a slow test suite that is often broken because it is too exact a fit for the exact strcuture of our current apps.

Is there a solution you'd like to recommend?

Weed out end-to-end tests to focus on essential use cases, don't cover all possible user journeys. Don't test state of too many components on screen but focus on essential indicators that app state is not broken.

[s-pic]

Hey @ciex will you add specific test suites you want to get rid off? Or shall I just go ahead?

[s-pic]

As discussed:

Our desired outcome is that

1. we can integrate e2e tests back into our CI
   done Add Github Action to run Cypress tests #533
2. we have simple but effective tests for the most important user paths in active projects (survey/kastaster_ki, project map, reports) covering our full stack
3. tests should run time-effective (with as few as possible page reloads)
4. our e2e tests do not concern much about how single components behave or look like, instead they make sure that certain user interactions navigate the user through the app and trigger data flows (backend-frontend)

So the deduced tasks are

• re-integrate tests in CI
  done Add Github Action to run Cypress tests #533
• eventually fix failing tests, see e3c5ef5
• I will reduce all e2e tests that could easily be replaced by unit-/integration-tests using react-testing-library
• I will optimize existing e2e tests to run more effectively in the manner described above

[cafca]

I have added it.skip() on all failing e2e tests in order to be able tun run the test suite on all others and not fail CI. If beforeEach or similar functions resulted in errors I have commented out whole blocks of tests.

See commit linked above this comment