You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: When poolState_.rate is very high, the assessed fee for deposits below the LUP (Lowest Utilized Price) will approach the entirety of the lender's deposit (note the calculation here); eventually, it even surpasses 100%, causing below-LUP deposit attempts to revert due to an underflow. Essentially, below-LUP deposits go from discouraged to impossible when rates in a pool are high. There is also the risk that a lender might not notice the incredibly high penalty and incur an almost total loss by accident.
Recommendation: Consider limiting the maximum below-LUP deposit fee.
Context: LenderActions.sol#L168
Description: When
poolState_.rate
is very high, the assessed fee for deposits below the LUP (Lowest Utilized Price) will approach the entirety of the lender's deposit (note the calculation here); eventually, it even surpasses 100%, causing below-LUP deposit attempts to revert due to an underflow. Essentially, below-LUP deposits go from discouraged to impossible when rates in a pool are high. There is also the risk that a lender might not notice the incredibly high penalty and incur an almost total loss by accident.Recommendation: Consider limiting the maximum below-LUP deposit fee.
Ajna: Maximum deposit fee capped to 10% in ajna-finance/ajna-core@1bf6ae9.
Prototech: Fix verified.
The text was updated successfully, but these errors were encountered: