Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags:v2.1] miscalculation of 'cols_offsets' in 'index_select_kernel'. #265

Open
Dayrker opened this issue Oct 29, 2024 · 0 comments
Open

Comments

@Dayrker
Copy link

Dayrker commented Oct 29, 2024

Describe the bug

位置:
FlagGems/tests/test_reduction_ops.py::test_accuracy_index_select
FlagGems/src/flag_gems/ops/index_select.py
现象:
cfggen中block_n去掉4096,设置block_n = [1024, 2048],则两个block_n值都会精度出错;
原因:
当block_n小于dim维度数据量时,计算出错;
line33: 应修改为cols_offsets = pid_y * BLOCK_N + tl.arange(0, BLOCK_N)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant