Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): Update entrypoint #4262

Merged
merged 4 commits into from
Jul 12, 2024
Merged

feat(docker): Update entrypoint #4262

merged 4 commits into from
Jul 12, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jun 27, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Allow arbitrary Django commands
  • Remove redundant commands
  • Remove deprecated go_to_sleep

How did you test this code?

Ran Docker build locally and verified arbitrary Django commands work.

@khvn26
feat(docker): Update entrypoint
304d5b1 
- Allow arbitrary Django commands
- Remove redundant commands
- Remove deprecated `go_to_sleep`
@khvn26 khvn26 requested a review from a team as a code owner June 27, 2024 16:06
@khvn26 khvn26 requested review from novakzaballa and removed request for a team June 27, 2024 16:06
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 8:57am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 8:57am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 8:57am

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2024 •
edited
Loading

Uffizzi Preview deployment-53584 was deleted.

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (bc9b340) to head (bdcfdd7).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4262   +/-   ##
=======================================
  Coverage   96.60%   96.61%           
=======================================
  Files        1194     1196    +2     
  Lines       39071    39123   +52     
=======================================
+ Hits        37745    37797   +52     
  Misses       1326     1326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 28, 2024
matthewelwell
matthewelwell reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I think there's probably a lot more that needs to go into this PR, right? How does the task definition for migrating projects from core to edge work? I'm pretty sure that's defined somewhere in the code, no?

We'll also need to update some documentation somewhere on how to perform the import / export behaviour now.

@khvn26 khvn26 requested a review from a team as a code owner July 12, 2024 08:57
@khvn26 khvn26 requested review from rolodato and removed request for a team July 12, 2024 08:57
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4262 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4262 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4262 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4262 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4262 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4262 Finished ✅ Results ✅

@khvn26
Copy link
Member Author

khvn26 commented Jul 12, 2024

@matthewelwell Good catches Matt — I've updated the ECS task and fixed the docs (they weren't correct in the first place)

@khvn26 khvn26 added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 759e745 Jul 12, 2024
34 checks passed
@khvn26 khvn26 deleted the feat/update-entrypoint branch July 12, 2024 09:08
@flagsmithdev flagsmithdev mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

@rolodato rolodato Awaiting requested review from rolodato rolodato is a code owner automatically assigned from Flagsmith/flagsmith-docs

Assignees
No one assigned
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khvn26 @matthewelwell @novakzaballa