Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wolfi-based Docker images #4276

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat: Wolfi-based Docker images #4276

merged 4 commits into from
Jul 18, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 2, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Use Wolfi OS as the base Docker image to avoid CVEs introduced by Debian base images.

How did you test this code?

Ran Docker build locally.
Ran the unit test suite and the E2E suite against the built image.

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 2:48pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 2:48pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2024 2:48pm

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Uffizzi Preview deployment-53759 was deleted.

@khvn26 khvn26 force-pushed the feat/wolfi-os-docker branch from ba42e80 to 7aef8e0 Compare July 2, 2024 21:35
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2024
@khvn26 khvn26 requested a review from a team as a code owner July 2, 2024 21:43
@khvn26 khvn26 requested review from zachaysan and removed request for a team July 2, 2024 21:43
@github-actions github-actions bot added api Issue related to the REST API feature New feature or request and removed feature New feature or request labels Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (1fa4990) to head (3f537b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4276   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files        1195     1195           
  Lines       39099    39099           
=======================================
  Hits        37773    37773           
  Misses       1326     1326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 2, 2024
@khvn26 khvn26 force-pushed the feat/wolfi-os-docker branch from 030682a to d65a83d Compare July 3, 2024 01:06
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 3, 2024
@khvn26 khvn26 requested a review from a team as a code owner July 4, 2024 16:39
@khvn26 khvn26 removed the request for review from a team July 4, 2024 16:39
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4276 Finished ✅ Skipped

Copy link
Contributor

github-actions bot commented Jul 4, 2024

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4276 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 4, 2024

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4276 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 4, 2024

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4276 Finished ✅ Results

@khvn26 khvn26 force-pushed the feat/wolfi-os-docker branch from 98ee827 to 9255c1b Compare July 4, 2024 20:11
Copy link
Contributor

github-actions bot commented Jul 4, 2024

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4276 Finished ✅ Results

Base automatically changed from chore/pipless to main July 5, 2024 09:35
@khvn26 khvn26 force-pushed the feat/wolfi-os-docker branch from 9255c1b to 8c40eaf Compare July 5, 2024 09:46
@khvn26 khvn26 force-pushed the feat/wolfi-os-docker branch 2 times, most recently from 383cc8a to 44c6d04 Compare July 5, 2024 09:48
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 5, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 8, 2024
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm not sure what considerations we need to make before merging @khvn26 ?

@khvn26
Copy link
Member Author

khvn26 commented Jul 12, 2024

@matthewelwell

  1. We need to make sure private cloud scenarios involving lxml work correctly.
  2. We need to test real-time flags on staging.

@khvn26 khvn26 added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 2e461c8 Jul 18, 2024
32 checks passed
@khvn26 khvn26 deleted the feat/wolfi-os-docker branch July 18, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants