Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix "Create Project" button in the project selector not opening the project creation modal #4294

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: Fix "Create Project" button in the project selector not opening the project creation modal #4294

merged 1 commit into from
Jul 12, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 8, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

@kyle-ssg kyle-ssg requested a review from a team as a code owner July 8, 2024 14:47
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team July 8, 2024 14:47
@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 2:49pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 2:49pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 8, 2024 2:49pm

@kyle-ssg kyle-ssg requested a review from rolodato July 8, 2024 14:47
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jul 8, 2024
@kyle-ssg kyle-ssg linked an issue Jul 8, 2024 that may be closed by this pull request
"Create Project" in project selector does not work #4284
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4294 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4294 Finished ✅ Skipped

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4294 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4294 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4294 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

Uffizzi Preview deployment-53950 was deleted.

novakzaballa
novakzaballa approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rolodato
rolodato approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Suggestion for a more specific title: fix: Fix "Create Project" button in the project selector not opening the project creation modal

@matthewelwell matthewelwell changed the title fix: create project link fix: Fix "Create Project" button in the project selector not opening the project creation modal Jul 12, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 1f9aecc Jul 12, 2024
28 checks passed
@matthewelwell matthewelwell deleted the fix/create-project-link branch July 12, 2024 14:01
@flagsmithdev flagsmithdev mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

@rolodato rolodato rolodato approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Create Project" in project selector does not work
4 participants
@kyle-ssg @rolodato @novakzaballa @matthewelwell