feat: Manage user's groups #4312

kyle-ssg · 2024-07-09T09:25:58Z

Thanks for submitting a PR! Please check the boxes below:

I have run pre-commit to check linting
I have added information to docs/ if required so people know about the feature!
I have filled in the "Changes" section below?
I have filled in the "How did you test this code" section below?
I have used a Conventional Commit title for this Pull Request

Changes

Todo: the API needs to return group_admin in /organisations/:id/groups for this to function correctly

How did you test this code?

Viewed / adjusted user permissions

vercel · 2024-07-09T09:26:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 0:08am
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 0:08am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		Nov 5, 2024 0:08am

github-actions · 2024-07-09T09:26:36Z

flagsmith-private-cloud image build and security scan finished ✨

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312`	Finished ✅	Results ✅

github-actions · 2024-07-09T09:26:36Z

flagsmith image build and security scan finished ✨

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith:pr-4312`	Finished ✅	Results ✅

github-actions · 2024-07-09T09:26:37Z

flagsmith-e2e image build finished ✨

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-e2e:pr-4312`	Finished ✅	Skipped

github-actions · 2024-07-09T09:26:41Z

flagsmith-frontend image build and security scan finished ✨

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-frontend:pr-4312`	Finished ✅	Results ✅

github-actions · 2024-07-09T09:26:43Z

flagsmith-api image build and security scan finished ✨

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api:pr-4312`	Finished ✅	Results ✅

github-actions · 2024-07-09T09:30:56Z

Uffizzi Preview deployment-57024 was deleted.

# Conflicts: # frontend/web/components/pages/UsersAndPermissionsPage.tsx

matthewelwell · 2024-10-30T09:33:27Z

@kyle-ssg group_admin has now been added to the user objects in the response to the GET /organisations/:id/groups/ endpoint. This has been deployed to staging so I think you can test this using the staging preview?

matthewelwell · 2024-10-30T13:44:21Z

@kyle-ssg this is a great addition, and seems to work well. The only criticism I would have is that it's very hidden - to get there, you have to click on 'Edit Permissions' which seems a bit odd. I'm not sure what the solution is here to be honest, maybe we can simply just change it to 'Manage user' ?

matthewelwell · 2024-10-30T13:45:13Z

Also, I'd argue that it's something that might be useful for admins now too - groups aren't only used for permissions - you can assign features and change requests to them, for example.

matthewelwell · 2024-10-30T13:46:30Z

github-actions · 2024-10-30T13:49:22Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api-test:pr-4312`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-4312`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-4312`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-4312`	Finished ✅	Results ✅

matthewelwell

Tested manually.

Toggle user groups

ff04601

kyle-ssg requested a review from a team as a code owner July 9, 2024 09:25

kyle-ssg requested review from novakzaballa and removed request for a team July 9, 2024 09:25

kyle-ssg requested a review from khvn26 July 9, 2024 09:26

vercel bot deployed to Preview – flagsmith-frontend-preview July 9, 2024 09:26 View deployment

github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Jul 9, 2024

kyle-ssg marked this pull request as draft July 9, 2024 09:26

vercel bot deployed to Preview – flagsmith-frontend-staging July 9, 2024 09:26 View deployment

kyle-ssg mentioned this pull request Jul 9, 2024

Add a convenient permissions view for group/project/organisation admins #4269

Closed

kyle-ssg linked an issue Jul 9, 2024 that may be closed by this pull request

Add a convenient permissions view for group/project/organisation admins #4269

Closed

Toggle user groups

4b4ccb1

github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 9, 2024

vercel bot deployed to Preview – flagsmith-frontend-preview July 9, 2024 09:33 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging July 9, 2024 09:33 View deployment

Merge branch 'refs/heads/main' into feat/view-users-groups

1da9f91

# Conflicts: # frontend/web/components/pages/UsersAndPermissionsPage.tsx

github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 8, 2024

vercel bot deployed to Preview – docs October 8, 2024 14:03 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview October 8, 2024 14:05 View deployment

vercel bot deployed to Preview – flagsmith-frontend-staging October 8, 2024 14:07 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview October 9, 2024 13:37 View deployment

matthewelwell mentioned this pull request Oct 29, 2024

feat: add group admin to list groups #4779

Merged

matthewelwell removed the request for review from novakzaballa October 29, 2024 17:45

matthewelwell marked this pull request as ready for review October 30, 2024 13:48

github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 30, 2024

matthewelwell requested review from matthewelwell and removed request for khvn26 October 30, 2024 16:09

Allow edit admin groups

40113cd

github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 5, 2024

Show email as edit user title if they have no name

b87c98a

github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 5, 2024

Manage user label

bf2785a

github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 5, 2024

vercel bot deployed to Preview – flagsmith-frontend-staging November 5, 2024 12:08 View deployment

vercel bot deployed to Preview – flagsmith-frontend-preview November 5, 2024 12:08 View deployment

matthewelwell approved these changes Nov 5, 2024

View reviewed changes

kyle-ssg added this pull request to the merge queue Nov 6, 2024

Merged via the queue into main with commit 89b153c Nov 6, 2024
30 checks passed

kyle-ssg deleted the feat/view-users-groups branch November 6, 2024 09:48

flagsmithdev mentioned this pull request Nov 6, 2024

chore(main): release 2.152.0 #4800

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Manage user's groups #4312

feat: Manage user's groups #4312

kyle-ssg commented Jul 9, 2024

vercel bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

matthewelwell commented Oct 30, 2024

matthewelwell commented Oct 30, 2024

matthewelwell commented Oct 30, 2024

matthewelwell commented Oct 30, 2024

github-actions bot commented Oct 30, 2024 •

edited

Loading

matthewelwell left a comment

feat: Manage user's groups #4312

feat: Manage user's groups #4312

Conversation

kyle-ssg commented Jul 9, 2024

Changes

How did you test this code?

vercel bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

github-actions bot commented Jul 9, 2024 • edited Loading

matthewelwell commented Oct 30, 2024

matthewelwell commented Oct 30, 2024

matthewelwell commented Oct 30, 2024

matthewelwell commented Oct 30, 2024

github-actions bot commented Oct 30, 2024 • edited Loading

Docker builds report

matthewelwell left a comment

Choose a reason for hiding this comment

vercel bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024 •

edited

Loading