fix: Catch full exception instead of runtime error in API usage task #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
zachaysan
changed the title
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4426 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 1167 1167
Lines 38684 38704 +20
=======================================
+ Hits 37462 37484 +22
+ Misses 1222 1220 -2 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Jul 31, 2024
zachaysan
deleted the
fix/catch_full_exception_instead_of_runtime_in_api_usage_task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When there were failures for individual organisations in the
handle_api_usage_notificationstask the catching code was too restrictive to allow for continued processing after failure. This change simply catches allExceptionclasses.How did you test this code?
I ran the test suite but I decided against writing a test for this since the logic is simple.
Edit: It looks like it's failing the code cov check, so I will bite the bullet and write out the test anyway.