Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: protect get environment document endpoint #4459

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Ensures that get_document endpoint is correctly protected by permissions.

How did you test this code?

Added a new unit test and updated existing one to ensure that the correct permission check is performed.

@matthewelwell matthewelwell requested a review from a team as a code owner August 7, 2024 09:18
@matthewelwell matthewelwell requested review from novakzaballa and removed request for a team August 7, 2024 09:18
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 7, 2024 9:18am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Aug 7, 2024 9:18am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Aug 7, 2024 9:18am

@github-actions github-actions bot added the api Issue related to the REST API label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4459 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4459 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4459 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4459 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4459 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4459 Finished ✅ Results

@github-actions github-actions bot added the fix label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Uffizzi Preview deployment-55037 was deleted.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.86%. Comparing base (3225c47) to head (dff0d11).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4459   +/-   ##
=======================================
  Coverage   96.85%   96.86%           
=======================================
  Files        1171     1171           
  Lines       38846    38854    +8     
=======================================
+ Hits        37626    37634    +8     
  Misses       1220     1220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit bee01c7 Aug 7, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/protect-get-environment-document-endpoint branch August 7, 2024 10:55
@rolodato rolodato added the security Security updates label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix security Security updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants