-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: protect get environment document endpoint #4459
Merged
matthewelwell
merged 2 commits into
main
from
fix/protect-get-environment-document-endpoint
Aug 7, 2024
Merged
fix: protect get environment document endpoint #4459
matthewelwell
merged 2 commits into
main
from
fix/protect-get-environment-document-endpoint
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
novakzaballa
and removed request for
a team
August 7, 2024 09:18
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
=======================================
Coverage 96.85% 96.86%
=======================================
Files 1171 1171
Lines 38846 38854 +8
=======================================
+ Hits 37626 37634 +8
Misses 1220 1220 ☔ View full report in Codecov by Sentry. |
khvn26
reviewed
Aug 7, 2024
khvn26
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures that
get_document
endpoint is correctly protected by permissions.How did you test this code?
Added a new unit test and updated existing one to ensure that the correct permission check is performed.