Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure MANAGE_TAGS permission allows create tag #4678

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes an issue found in testing #4615 where it was not possible to create a tag when a user had the MANAGE_TAGS permission.

How did you test this code?

Added new tests to confirm both negative and positive cases.

@matthewelwell matthewelwell requested a review from a team as a code owner October 1, 2024 14:36
@matthewelwell matthewelwell requested review from zachaysan and removed request for a team October 1, 2024 14:36
@github-actions github-actions bot added the api Issue related to the REST API label Oct 1, 2024
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 1, 2024 2:36pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 1, 2024 2:36pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 1, 2024 2:36pm

@github-actions github-actions bot added the fix label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4678 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4678 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4678 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4678 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4678 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4678 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Uffizzi Preview deployment-56808 was deleted.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (59aa2f7) to head (99ce47b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4678   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files        1166     1166           
  Lines       40436    40447   +11     
=======================================
+ Hits        39301    39312   +11     
  Misses       1135     1135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 58eb9ed Oct 2, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/manage-tags-permission-for-create branch October 2, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants