Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions): update endpoints to expose tag-supported perms #4788

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Oct 31, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add supports_tag boolean to the data returned by the {project/environment}/permissions endpoints to make the UI aware of permissions that support tags. See: #1535 (comment)

How did you test this code?

Covered by updated unit tests

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 4:22am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 4:22am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 4:22am

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Oct 31, 2024
@gagantrivedi gagantrivedi marked this pull request as ready for review October 31, 2024 09:35
@gagantrivedi gagantrivedi requested a review from a team as a code owner October 31, 2024 09:35
@gagantrivedi gagantrivedi requested review from zachaysan and removed request for a team October 31, 2024 09:35
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4788 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4788 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4788 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4788 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4788 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Uffizzi Preview deployment-57809 was deleted.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (483cc87) to head (c425328).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4788   +/-   ##
=======================================
  Coverage   97.32%   97.33%           
=======================================
  Files        1179     1179           
  Lines       41188    41209   +21     
=======================================
+ Hits        40088    40109   +21     
  Misses       1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one question.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 4, 2024
@gagantrivedi gagantrivedi added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 43e68c1 Nov 4, 2024
34 checks passed
@gagantrivedi gagantrivedi deleted the feat/expose-tag-supported-permissions branch November 4, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants