-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permissions): update endpoints to expose tag-supported perms #4788
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4788 +/- ##
=======================================
Coverage 97.32% 97.33%
=======================================
Files 1179 1179
Lines 41188 41209 +21
=======================================
+ Hits 40088 40109 +21
Misses 1100 1100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just one question.
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Add
supports_tag
boolean to the data returned by the{project/environment}/permissions
endpoints to make the UI aware of permissions that support tags. See: #1535 (comment)How did you test this code?
Covered by updated unit tests