Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Gunicorn logger not sending StatsD stats #4819

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Nov 7, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This enables StatsD support for our own GunicornJsonCapableLogger.

How did you test this code?

Will test manually with @rolodato's StatsD debug setup.

@khvn26 khvn26 requested a review from a team as a code owner November 7, 2024 09:20
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team November 7, 2024 09:20
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 4:41pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 4:41pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 4:41pm

@github-actions github-actions bot added the api Issue related to the REST API label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4819 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4819 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4819 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4819 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4819 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4819 Finished ✅ Results

@github-actions github-actions bot added the fix label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Uffizzi Preview deployment-58057 was deleted.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (e6f1bac) to head (d63f10e).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4819      +/-   ##
==========================================
+ Coverage   97.33%   97.35%   +0.02%     
==========================================
  Files        1180     1182       +2     
  Lines       41223    41272      +49     
==========================================
+ Hits        40123    40179      +56     
+ Misses       1100     1093       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Nov 7, 2024
Copy link
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing coverage

@github-actions github-actions bot added fix and removed fix labels Nov 13, 2024
@khvn26 khvn26 requested a review from gagantrivedi November 13, 2024 22:24
@khvn26 khvn26 merged commit 9bbfdf0 into main Nov 14, 2024
34 checks passed
@khvn26 khvn26 deleted the fix/statsd-gunicorn-logging branch November 14, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants