Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flagsmith stale flags check #4831

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: flagsmith stale flags check #4831

merged 1 commit into from
Nov 12, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fix flagsmith flag check, it was incorrectly using the isomorphic library instead of the standard, this also uses our standard util function.

How did you test this code?

Validated the site loads correctly and the flag is evaluated

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 12, 2024 15:05
@kyle-ssg kyle-ssg requested a review from rolodato November 12, 2024 15:05
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 3:05pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 3:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 12, 2024 3:05pm

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4831 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4831 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4831 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4831 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4831 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4831 Finished ✅ Results

@kyle-ssg kyle-ssg merged commit ea6a169 into main Nov 12, 2024
19 checks passed
@kyle-ssg kyle-ssg deleted the fix/flagsmith-flag-check branch November 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants