Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow teardown to use FLAGSMITH_API_URL #4849

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Uses FLAGSMITH_API_URL for the e2e teardown if it is set.

How did you test this code?

Confirmed FLAGSMITH_API_URL=x npm run test uses the correct teardown.

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 20, 2024 10:34
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:36am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 20, 2024 10:36am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4849 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4849 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4849 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4849 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4849 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4849 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Uffizzi Preview deployment-58401 was deleted.

@matthewelwell matthewelwell merged commit 9ad8da6 into main Nov 20, 2024
30 checks passed
@matthewelwell matthewelwell deleted the fix/e2e-teardown-environment-variable branch November 20, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants