Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tag based permissions #4853

Merged
merged 29 commits into from
Dec 4, 2024
Merged

feat: tag based permissions #4853

merged 29 commits into from
Dec 4, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 20, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

image

How did you test this code?

  • Created a role with relevant permissions restricted to a set of tags
  • Tested as a user with that role
tag-based-permissions.mov

@kyle-ssg
Add tag based permissions
83b3b2e
@kyle-ssg
Merge branch 'refs/heads/main' into feat/tag-based-permissions
c8d4532 
# Conflicts:
#	frontend/common/types/requests.ts
#	frontend/web/components/tags/AddEditTags.tsx
@kyle-ssg
Merge
58e6478
@kyle-ssg
Tag based permissions flag
dcef5ae
@kyle-ssg
Add tag based permissions ui
82519f2
@kyle-ssg
tag based role ui
716706b
@kyle-ssg
Add tag_based_permissions logic to frontend
2c71cfa
@kyle-ssg
Merge branch 'refs/heads/main' into feat/tag-based-permissions-valida…
3634609 
…tion

# Conflicts:
#	frontend/web/components/pages/UserPage.tsx
@kyle-ssg
Adjust tag base permissions data structure
985cceb
@kyle-ssg
Adjust tag base permissions data structure
c09d39b
@kyle-ssg
Better permissions view for create feature
a940e9a
@kyle-ssg
Merge branch 'refs/heads/main' into feat/tag-based-permissions
750054b 
# Conflicts:
#	frontend/web/components/EditPermissions.tsx
@kyle-ssg
Merge branch 'refs/heads/main' into feat/tag-based-permissions
1837651
@kyle-ssg
Remove static tag_based variable
48d54c5
@kyle-ssg
Remove incorrect function call
f962c1c
@kyle-ssg
Adjust doc wording
243c7a4
@kyle-ssg
Merge branch 'refs/heads/main' into feat/tag-based-permissions
9ad625f
@kyle-ssg
Permissions v2
bf5d177
@kyle-ssg
Tag based permissions UI
72e5d8c
@kyle-ssg
Merge branch 'refs/heads/main' into feat/tag-based-permissions-v2
195c400
@kyle-ssg
Interop edit permissions / role-based permissions
d2b7011
@kyle-ssg
Adjust UI for limited permissions
8482f89
@kyle-ssg
LIMITED > GRANTED_FOR_TAGS
29051be
@kyle-ssg kyle-ssg requested review from a team as code owners November 20, 2024 13:33
@kyle-ssg kyle-ssg requested review from khvn26 and removed request for a team November 20, 2024 13:33
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 11:48am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 11:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 11:48am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Nov 20, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 3, 2024
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Dec 3, 2024
@kyle-ssg kyle-ssg marked this pull request as ready for review December 3, 2024 12:21
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Dec 3, 2024
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Dec 4, 2024
@flagsmith flagsmith bot added the flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith label Dec 4, 2024
@flagsmith Flagsmith
Copy link

flagsmith bot commented Dec 4, 2024

Flagsmith feature linked: tag_based_permissions
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2024-10-30 19:20:04

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-10-30 19:20:04
Staging ✅ Enabled 2024-09-18 15:18:34
Demo ❌ Disabled 2024-10-30 19:17:41
Demo ✅ Enabled 2024-10-30 19:17:41
Self hosted defaults ❌ Disabled 2024-09-18 15:13:59

@kyle-ssg kyle-ssg merged commit 7c4e2ff into main Dec 4, 2024
32 checks passed
@kyle-ssg kyle-ssg deleted the feat/tag-based-permissions-v2 branch December 4, 2024 13:20
@flagsmithdev flagsmithdev mentioned this pull request Dec 4, 2024
Merged
@flagsmith Flagsmith
Copy link

flagsmith bot commented Dec 4, 2024

Flagsmith Feature tag_based_permissions has been updated:

Environment Enabled Value Last Updated (UTC)
Demo ✅ Enabled 2024-12-04 14:06:51

@flagsmith Flagsmith
Copy link

flagsmith bot commented Dec 4, 2024

Flagsmith Feature tag_based_permissions has been updated:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-12-04 14:07:01

@flagsmith Flagsmith
Copy link

flagsmith bot commented Dec 5, 2024

Flagsmith Feature tag_based_permissions has been updated:

Segment qbiq values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-12-05 16:04:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagantrivedi gagantrivedi gagantrivedi approved these changes

@khvn26 khvn26 Awaiting requested review from khvn26 khvn26 is a code owner automatically assigned from Flagsmith/flagsmith-docs

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

Assignees
No one assigned
Labels
feature New feature or request flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @gagantrivedi