Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Hubspot cookie logging #4854

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

zachaysan
Copy link
Contributor

Changes

I'm diagnosing missing records and so I've added some temporary Hubspot logger code.

How did you test this code?

Existing tests should cover the code paths and it's not necessary to add tests for the logging.

@zachaysan zachaysan requested a review from a team as a code owner November 20, 2024 16:36
@zachaysan zachaysan requested review from matthewelwell and removed request for a team November 20, 2024 16:36
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 20, 2024 4:36pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Nov 20, 2024 4:36pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Nov 20, 2024 4:36pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4854 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4854 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4854 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4854 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4854 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4854 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Uffizzi Preview deployment-58425 was deleted.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (86ba762) to head (453dde6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4854   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files        1183     1183           
  Lines       41306    41311    +5     
=======================================
+ Hits        40213    40218    +5     
  Misses       1093     1093           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@matthewelwell matthewelwell merged commit 8fe4d41 into main Nov 21, 2024
34 checks passed
@matthewelwell matthewelwell deleted the feat/add_hubspot_cookie_logging branch November 21, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants