Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Environment Ready Checker #4865

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fix: Environment Ready Checker #4865

merged 4 commits into from
Nov 26, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

The environment ready checker will now stop polling once the environment exists and is_creating is false.

How did you test this code?

  • Create an environment
  • Validate that the environment goes to the processing screen
  • Validate that the environment stops polling

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 26, 2024 10:17
@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 10:26am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 10:26am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:26am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4865 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4865 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4865 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4865 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4865 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4865 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4865 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4865 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4865 Finished ✅ Results ✅

@github-actions github-actions bot added fix and removed fix labels Nov 26, 2024
@github-actions github-actions bot added fix and removed fix labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Uffizzi Preview deployment-58577 was deleted.

@github-actions github-actions bot added fix and removed fix labels Nov 26, 2024
@matthewelwell matthewelwell merged commit 2392222 into main Nov 26, 2024
30 checks passed
@matthewelwell matthewelwell deleted the fix/environment-creating-checker branch November 26, 2024 14:00
@flagsmithdev flagsmithdev mentioned this pull request Nov 26, 2024
Merged
@kyle-ssg kyle-ssg linked an issue Nov 27, 2024 that may be closed by this pull request
UI is continuously fetching the environment. #4856
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI is continuously fetching the environment.
2 participants
@kyle-ssg @matthewelwell