Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(environment/views): Add get-by-uuid action #4875

Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat(environment/views): Add get-by-uuid action #4875

merged 1 commit into from
Nov 29, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Nov 29, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add uuid to the environment model.
  • Add get-by-uuid action to support fetching environment using UUID

How did you test this code?

Add unit tests

@vercel Vercel
Copy link

vercel bot commented Nov 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 11:13am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 11:13am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 11:13am

@github-actions github-actions bot added the api Issue related to the REST API label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Uffizzi Preview deployment-58673 was deleted.

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (6ad5e76) to head (2185053).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4875   +/-   ##
=======================================
  Coverage   97.37%   97.38%           
=======================================
  Files        1186     1187    +1     
  Lines       41261    41301   +40     
=======================================
+ Hits        40179    40219   +40     
  Misses       1082     1082

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi changed the title wip(env/viewset): Add support for uuid as lookup feat(environment): Add support for uuid as lookup_field Nov 29, 2024
@gagantrivedi gagantrivedi force-pushed the feat/add-uuid-to-environment branch from e8a4c85 to 80a556b Compare November 29, 2024 09:01
@github-actions github-actions bot added the feature New feature or request label Nov 29, 2024
@gagantrivedi gagantrivedi marked this pull request as ready for review November 29, 2024 09:07
@gagantrivedi gagantrivedi requested a review from a team as a code owner November 29, 2024 09:07
@gagantrivedi gagantrivedi requested review from matthewelwell and removed request for a team November 29, 2024 09:07
@github-actions github-actions bot removed the feature New feature or request label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4875 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4875 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4875 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4875 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4875 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4875 Finished ✅ Results ✅

@github-actions github-actions bot added the feature New feature or request label Nov 29, 2024
@gagantrivedi gagantrivedi force-pushed the feat/add-uuid-to-environment branch from 80a556b to 43d1114 Compare November 29, 2024 09:24
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 29, 2024
matthewelwell
matthewelwell reviewed Nov 29, 2024
View reviewed changes
api/features/versioning/managers.py Outdated Show resolved Hide resolved
api/environments/views.py Outdated Show resolved Hide resolved
@gagantrivedi gagantrivedi force-pushed the feat/add-uuid-to-environment branch from 43d1114 to 45077d0 Compare November 29, 2024 11:07
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 29, 2024
@gagantrivedi gagantrivedi force-pushed the feat/add-uuid-to-environment branch from 45077d0 to 2185053 Compare November 29, 2024 11:12
@gagantrivedi gagantrivedi changed the title feat(environment): Add support for uuid as lookup_field feat(environment/views): Add get-by-uuid action Nov 29, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 29, 2024
@gagantrivedi gagantrivedi merged commit db8433b into main Nov 29, 2024
34 checks passed
@gagantrivedi gagantrivedi deleted the feat/add-uuid-to-environment branch November 29, 2024 11:24
@flagsmithdev flagsmithdev mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gagantrivedi @matthewelwell