Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot create new segments due to segment validation #4886

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes issues with segment creation due to the validation on the number of segments not excluding old versions.

How did you test this code?

Added a new test

@matthewelwell matthewelwell requested a review from a team as a code owner December 4, 2024 09:34
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team December 4, 2024 09:35
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 10:51am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 10:51am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 10:51am

@github-actions github-actions bot added api Issue related to the REST API fix labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4886 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4886 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4886 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4886 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4886 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4886 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Uffizzi Preview deployment-58806 was deleted.

@github-actions github-actions bot added fix and removed fix labels Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (4e1abda) to head (b112f59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4886   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files        1189     1189           
  Lines       41409    41420   +11     
=======================================
+ Hits        40327    40338   +11     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 05ab7cf into main Dec 4, 2024
34 checks passed
@matthewelwell matthewelwell deleted the fix/segment-creation-limit-versioning branch December 4, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants