Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Incorrect mock in test_ensure_identity_traits_blanks__exclusive_start_key__calls_expected #4944

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jan 2, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes failing test_ensure_identity_traits_blanks__exclusive_start_key__calls_expected test by correcting the mocked method name.

How did you test this code?

The tests now pass.

@khvn26 khvn26 requested a review from a team as a code owner January 2, 2025 13:48
@khvn26 khvn26 requested review from matthewelwell and removed request for a team January 2, 2025 13:48
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 2, 2025 1:48pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jan 2, 2025 1:48pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jan 2, 2025 1:48pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4944 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4944 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4944 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4944 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4944 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4944 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Uffizzi Preview deployment-59438 was deleted.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (6d96f9b) to head (06026b3).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4944   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1191     1191           
  Lines       41535    41552   +17     
=======================================
+ Hits        40453    40470   +17     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit bbe7db1 into main Jan 2, 2025
35 checks passed
@matthewelwell matthewelwell deleted the fix/name-error branch January 2, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants