Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for quickly navigating to recently created or existing requested changes #5109

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Feb 14, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ref: #4114

  • Replaced WarningMessage with InfoMessage, added new properties, and improved the handling of change requests.
  • Added new properties to ExistingChangeRequestAlert
  • Updates Toast position and layout to make it more visible for the user
  • Adds Action property to Toast

Info Message

Screenshot 2025-02-14 at 19 23 16 Screenshot 2025-02-14 at 19 26 41

Toast

Untitled

How did you test this code?

  • Did regression testing for Toast component
  • Tested both scheduled and request changes

@tiagoapolo tiagoapolo requested a review from a team as a code owner February 14, 2025 22:39
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team February 14, 2025 22:39
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 8:19pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 8:19pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 8:19pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5109 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5109 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5109 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5109 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5109 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5109 Finished ✅ Results

@tiagoapolo tiagoapolo changed the title Feat/4114 nav to created change request feat: adds ways for quickly navigating to recently created or existing requested changes Feb 14, 2025
@tiagoapolo tiagoapolo changed the title feat: adds ways for quickly navigating to recently created or existing requested changes feat: Adds support for quickly navigating to recently created or existing requested changes Feb 14, 2025
@tiagoapolo tiagoapolo self-assigned this Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Uffizzi Preview deployment-60952 was deleted.

@kyle-ssg
Copy link
Member

It'd be good to just get a second pair of eyes on the new toast placement, tested other bits and looks good

@tiagoapolo tiagoapolo merged commit e7b1adc into main Feb 18, 2025
33 checks passed
@tiagoapolo tiagoapolo deleted the feat/4114--nav-to-created-change-request branch February 18, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants