Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add printing detailed messages for Flank's errors. #1036

Closed
pawelpasterz opened this issue Aug 21, 2020 · 1 comment · Fixed by #1043
Closed

feat: Add printing detailed messages for Flank's errors. #1036

pawelpasterz opened this issue Aug 21, 2020 · 1 comment · Fixed by #1043
Assignees
@pawelpasterz
Labels
Feature Snake 🐍

Comments

@pawelpasterz
Copy link
Contributor

In Flank there is a function Utlis#withGlobalExecptionHandling which is a kind of wrapper to main and its duty is to handle all flank's custom errors.
MatrixCanceledError and InfrastructureError detailed messages are not printed.

We should implement a logic to print detailed message (or default one)
@pawelpasterz pawelpasterz self-assigned this Aug 21, 2020
@pawelpasterz
Copy link
Contributor Author

Waiting for #1028 to be merged first

@pawelpasterz pawelpasterz changed the title feat: Some errors do not print details when handled. feat: Add printing detailed messages for Flank's errors. Aug 21, 2020
@pawelpasterz pawelpasterz mentioned this issue Aug 22, 2020
Merged
@mergify mergify bot closed this as completed in #1043 Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelpasterz pawelpasterz

Labels
Feature Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add printing messages for MatrixCanceledError and InfrastructureError Flank/flank
1 participant
@pawelpasterz