-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid releasing on documentation only changes #1046
Comments
After a little bit of research I can see mainly two ways to approach it. But instead of simply just submitting code i would prefer to get some opinions first.
Is there any other solution that I may have missed? @piotradamczyk5 you are the most familiar with this process. what do you think? |
If you look at Bitrise (create an account, use selective builds), they have a glob pattern that defines when builds can be triggered. I think we could build something similar using a GitHub action. For example, only build if changes are in |
@Sloox you could filter file paths . Please read how to do it in documentation We have some filtering for flank scripts. Your proposed solution #1 is not good, because it will fail job if nothing changes. Also, I think that we should only filter documentation changes for |
agreed |
Thanks will look and get back to you. |
Author the user story for this feature
As a Flank developer, I want to only release snapshots when the code changes so I can save CI compute resources.
Is your feature request related to a problem? Please describe.
Merging a pull request that only ever changes readme.md will produce a new flank snapshot. Let's modify the release pipeline to only perform releases on code changes. As Flank is becoming more of a monorepo, we can add intelligence to CI so that builds only happen when they make sense.
The text was updated successfully, but these errors were encountered: