Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Cucumber tests if there is not other Instrumented tests included #1189

Closed
piotradamczyk5 opened this issue Oct 2, 2020 · 3 comments
Closed

Comments

@piotradamczyk5
Copy link
Contributor

Author the user story for this feature

As a User, I want to run Cucumber tests, even I do not have another Instrumented tests in my test suite so I can run tests with a Cucumber-only test suite using Flank.

Is your feature request related to a problem? Please describe.
For now, Gcloud could run tests even apk contains Cucumber only tests.
Flank fast fail with the message No tests to run (disabling fast fail do not fix this situation)

Describe the solution you'd like
Provide additional flag ex. only-cucumber-tests which indicate that the new Matrix should be created

Describe alternatives you've considered
0. Described solution

  1. Print a warning message that other tests should be included
  2. Always create a matrix and try to run tests even for empty apks
  3. Leave it as it is with information about this in FAQ section of Flank

Additional context
See PR connected to issue #1118 for more information

@bootstraponline @jan-gogo @pawelpasterz @adamfilipow92 @Sloox @axelzuziak-gogo
WDYT?

@bootstraponline
Copy link
Contributor

@piotradamczyk5 the existing disable sharding flag should allow Flank to run cucumber tests.

@bootstraponline
Copy link
Contributor

If the flag is enabled then we should skip the test count check.

@bootstraponline
Copy link
Contributor

@piotradamczyk5 as Cucumber is not officially supported by FTL I think we can pause work on this in favor of higher priority tickets. Thanks for the investigation and updating the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants