Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print run duration #1666

Closed
asadsalman opened this issue Mar 5, 2021 · 1 comment · Fixed by #1773
Closed

Print run duration #1666

asadsalman opened this issue Mar 5, 2021 · 1 comment · Fixed by #1773

Comments

@asadsalman
Copy link
Contributor

It would be great if Flank prints the duration of the entire execution at the end. The intermediate steps duration breakdown is really great! But it would be really nice if, at the end of everything, Flank could print the combined duration.

@jan-goral jan-goral added the Porch Issue have to be clarified label Mar 18, 2021
@Sloox
Copy link
Contributor

Sloox commented Mar 18, 2021

We potentially see 3 different possible runs to print and they can be explained as follows:

  1. Entire execution of the Flank run where it is timed from the start of Flank Execution and until it shuts down.
  2. Entire execution of the interaction with Google Firebase CLI, i.e. The time from when the tests execute till when they shutdown.
  3. Total cost duration, a flank estimate of the time that is billed for (Ultimately the correct source of truth will be the final billing cost)

Some notes

  1. Can be calculated by simply summing up the intemediatry steps.
  2. Might need some work to seperate out where exactly the CLI is interacted with
  3. Is a tricky one and needs to be discussed if we should approach it (Due to possibility of being incorrect and legal issues)

@jan-gogo WDYT?

@jan-goral jan-goral added P1 and removed Porch Issue have to be clarified labels Mar 18, 2021
@zuziaka zuziaka changed the title Print run duartion Print run duration Mar 30, 2021
@piotradamczyk5 piotradamczyk5 self-assigned this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants