New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style overrides with CSS variables does not work with Angular SDK #240

Open

amuelli opened this issue Jan 6, 2025 · 1 comment

amuelli commented Jan 6, 2025 •

edited by alnoorp

Loading

#triage-eng-support thread

Based on the documentation here the following CSS variables can be used to customize elements outside the iframe:

:root {
  --ff-primary-color: #4c48ef !important;
  --ff-secondary-color: #616a7d !important;
  --ff-text-color: #090b2b !important;
  --ff-dialog-border-radius: 4px !important;
  --ff-border-radius: 5px !important;
  --ff-bg-fade: rgba(0, 0, 0, 0.2) !important;
}

This is currently not the case for the Angular SDK as these variables exist only as SASS variables that are initiated with the default values.

flatfile-core-libraries/packages/angular/angular-sdk/src/lib/sdk/space-close-modal/spaceCloseModal.component.scss

Lines 1 to 6 in 6773e36

    
           $ff-primary-color: #4c48ef; 
        
           $ff-secondary-color: #616a7d; 
        
           $ff-text-color: #090b2b; 
        
           $ff-dialog-border-radius: 4px; 
        
           $ff-border-radius: 5px; 
        
           $ff-bg-fade: rgba(0, 0, 0, 0.2);

The text was updated successfully, but these errors were encountered:

Arsik36 commented Jan 6, 2025

Hey Amuelli, thanks for reporting this! We'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment