Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Minimum Time Before Requesting Review #2

Open
joeljfischer opened this issue Mar 8, 2024 · 2 comments · May be fixed by #4
Open

[Feat] Minimum Time Before Requesting Review #2

joeljfischer opened this issue Mar 8, 2024 · 2 comments · May be fixed by #4

Comments

@joeljfischer
Copy link

Problem Statement

If a user is just checking my app out for the first time, I don't want to request a review from them yet.

Suggested Solution

I could set the threshold for events higher, but it would be better if I were able to set a minimum time after first install / first event in the queue before requesting a review.

Additional Considerations

You are already recording the time for the events, so adding a check for minimum time since the first event shouldn't be too difficult. Then it would just be a configuration option. I'd suggest the default be one day.

@joeljfischer
Copy link
Author

I'm planning to create a PR for this

@joeljfischer joeljfischer linked a pull request Mar 9, 2024 that will close this issue
@Jeehut
Copy link
Member

Jeehut commented Sep 21, 2024

@joeljfischer Sorry for getting back to this so late, somehow this slipped through my inbox. But now I just left a few comments in your PR. Thank you for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants