Fix issue #171 - Added super.destroy() to all overridden destroy() methods
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GitHub issue AdamAtomic#171 AdamAtomic#171 In some places, `super.destroy()` was not required. For instance, some classes extended `FlxBasic` which does not have any content in the `destroy()` method. However, just to be safe (and in case that function gets populated at a later date), calling super was added anyway.
|
This looks fine, I'm happy for it to be merged. |
|
This looks fine to me too. I am glad it was fixed because it can produce some serious memory leaks. Great, @IQAndreas ! |
IQAndreas
added a commit
that referenced
this pull request
Sep 16, 2012
Fix issue #171 - Added `super.destroy()` to all overridden `destroy()` methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GitHub issue #171
AdamAtomic#171
In some places,
super.destroy()was not required. For instance, someclasses extended
FlxBasicwhich does not have any content in thedestroy()method.However, just to be safe (and in case that function gets populated at a
later date), calling super was added anyway.