Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working in system wide windows installation #148

Open
swirly opened this issue Feb 15, 2017 · 3 comments
Open

not working in system wide windows installation #148

swirly opened this issue Feb 15, 2017 · 3 comments

Comments

@swirly
Copy link

swirly commented Feb 15, 2017

We are working in a school with windows 7 workstation

In order to work in our school, we install atom in %PROGRAMFILES% by unzipping instead of %localappdata%

Atom works but the floobits plugin does not work anymore. We can sign in, we can join a workspace but after that, nothing happens. Just the .floo file with URL is created, but no file is synced

It seems that the plugin somehow rely on atom being installed in %localappdata%

@swirly
Copy link
Author

swirly commented Mar 29, 2017

Tried again today
floobits install fines
cannot join workspace
cannot create workspace

seems to be a permission problem

@swirly
Copy link
Author

swirly commented Mar 29, 2017

This is indeed a permission problem. Tried with an admin account. It write in
C:\Program Files\Atom~\floobits\persistent.json

The ~is not evaluated in windows and it writes in a system folder where a normal user shall not write

The pugin shoud use ATOM_HOME variable

@swirly
Copy link
Author

swirly commented Mar 29, 2017

Ok. Found the source of the bug

persistentjson.js in lib/common

line 7 and up

function PersistentJson() {
this.data = {};
this.path = fs.absolute("~/floobits/persistent.json");
}

the path should be fixed using ATOM_HOME
maybe un upgrade process should be invoked in case of package upgrading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant