Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis non showing #458

Closed
Jaked2001 opened this issue Apr 14, 2024 · 32 comments
Closed

Emojis non showing #458

Jaked2001 opened this issue Apr 14, 2024 · 32 comments
Assignees
Labels
bug Something isn't working

Comments

@Jaked2001
Copy link

Jaked2001 commented Apr 14, 2024

Describe the bug
Emojis in text in editing mode do not show

To Reproduce
It's unclear to me how to reproduce this, since it seems to have an irregular behavior.
Anyhow, my notes seem to not be able to show emojis in the text.

Expected behavior
I expect to see emojis

Additional context
To problem seems to solve it self right way when disabling the iconize plugin
plugin version: 2.11.11

@FlorianWoelki
Copy link
Owner

Describe the bug

Emojis in text in editing mode do not show

To Reproduce

It's unclear to me how to reproduce this, since it seems to have an irregular behavior.

Anyhow, my notes seem to not be able to show emojis in the text.

Expected behavior

I expect to see emojis

Additional context

To problem seems to solve it self right way when disabling the iconize plugin

plugin version: 2.11.11

thanks for reporting. does it work if you set the option emoji mode in the Iconize settings to native?

@FlorianWoelki FlorianWoelki added the question Further information is requested label Apr 14, 2024
@quanru
Copy link
Contributor

quanru commented Apr 14, 2024

I set the emoji mode to native, but the problem still exists.

@Medenor
Copy link

Medenor commented Apr 14, 2024

I have the same issue since a few days, I also tried to set the emoji mode to native, but the problem still exists.

plugin version: 2.11.11 (but I already had the issue with the previous version)

@Jaked2001
Copy link
Author

thanks for reporting. does it work if you set the option emoji mode in the Iconize settings to native?

No. I never actually changed it from "native"

@Jaked2001
Copy link
Author

plugin version: 2.11.11 (but I already had the issue with the previous version)

Yeah, me too. It's been a problem for a couple of days at least

@frombrosis
Copy link

I have the same issue. It started occurring when the change was made in the plugin settings to ‘none’ to ‘default’ or similar. Before that change, it was working beautifully. For now, I have disabled this plugin unfortunately…

@m-beau
Copy link

m-beau commented Apr 15, 2024

Yeah all the emojis are broken across obsidian since the last iconize update!! It renders the package absolutely unusable!

@FlorianWoelki
Copy link
Owner

I need more information to reproduce the issue.

  • Are there any error logs in the Developer Console?
  • Is the problem still reproducible when you only have Iconize in your Vault without other plugins
  • When does the error exactly occur?

@Stefanyeah
Copy link

Stefanyeah commented Apr 15, 2024

I'm having the same problem.

Is the problem still reproducible when you only have Iconize in your Vault without other plugins
Switched off all plugins apart from Iconize and the problem presists. I'm using AnupPuccin as a theme.

When does the error exactly occur?
Almost always.
The icons are shown:

  • in Dataview tables
  • when the cursor is in the same line
  • within callouts (unless I'm editing the callout. Then no icons are shown)

Edit: I'm also usually in Live Preview
Obsidian: 1.5.12
Iconize: 2.11.11

Edit 2: I've tried Iconize in my vault that uses Minimal, the moment I switched the plug in on, all the emojis disappeared.

@pyxelr
Copy link

pyxelr commented Apr 15, 2024

I have the same problem in Live Preview mode.

With Iconize 2.11.5:

2024-04-15_20-58-24

After updating to the latest Iconize 2.11.11, the same problem occurs on Windows, macOS, and Android:

2024-04-15_21-00-16

Here is my default Iconize setup from .obsidian/plugins/obsidian-icon-folder/data.json:

{
  "settings": {
    "migrated": 4,
    "iconPacksPath": ".obsidian/plugins/obsidian-icon-folder/icons",
    "fontSize": 16,
    "iconColor": null,
    "recentlyUsedIcons": [
      "🕑",
      "🧑‍🍳",
      "🍖",
      "🅿",
      "🥊"
    ],
    "recentlyUsedIconsSize": 5,
    "rules": [
      {
        "icon": "",
        "rule": "+LEARN 🚧/DATA SCIENCE 🚧/Courses 🚧/MATLAB 🚧/(YouTube) MATLAB Tutorial - Derek Banas 🚧.md\\/[\\w\\d\\s]+\\.(?:\\w+\\.)*\\w+",
        "for": "files",
        "order": 0,
        "useFilePath": true
      }
    ],
    "extraPadding": {
      "top": 2,
      "right": 2,
      "bottom": 2,
      "left": 2
    },
    "extraMargin": {
      "top": 0,
      "right": 4,
      "bottom": 0,
      "left": 0
    },
    "emojiStyle": "twemoji",
    "iconInTabsEnabled": true,
    "iconsBackgroundCheckEnabled": false,
    "iconInTitleEnabled": false,
    "iconInFrontmatterEnabled": false,
    "iconsInNotesEnabled": true,
    "iconIdentifier": ":",
    "iconsInLinksEnabled": true,
    "iconInFrontmatterFieldName": "icon",
    "iconColorInFrontmatterFieldName": "iconColor",
    "debugMode": false
  },

I cannot find anything interesting in the developer console. When I activate Iconize, there is only this single log line in the console (with or without "debug mode" in Iconize settings):

loading iconize plugin:obsidian-icon-folder:5836 

@rotane
Copy link

rotane commented Apr 15, 2024

Same issue, exactly as @Stefanyeah describes. Emojis only show up when my cursor is on the same line/block; in DataView blocks; and in Callouts (unless when editing).

I'm pretty much always in Live Preview. No theme, just CSS snippets (but the issue persists with them disabled).

Obsidian 1.5.12, Iconize 2.11.11

@Jaked2001
Copy link
Author

Jaked2001 commented Apr 15, 2024

I'm experiencing the problem just as @Stefanyeah described it. I am also using Anapuccin as a theme. I wonder if there might be some problem related to that (?)

EDIT: I've just tried disabling Anapuccin and reloading Obsidian with iconize active. Didn't solve it.

@FlorianWoelki
Copy link
Owner

not entirely sure if the newest built version fixes this problem. i've tweaked some things. this link is the currently built version. it would be really nice, if someone could tell me if everything works fine or if there is still an issue.

here are the things you need to do to install the main.js file:

  1. Go to your .obsidian folder (you can e.g., access that through Obsidian _Settings > Appearance > Themes (and click on the directory icon))
  2. Go to the plugin directory (should be .obsidian/plugins/obsidian-icon-folder/)
  3. Replace the main.js file with the newly downloaded main.js file

@Jaked2001
Copy link
Author

Jaked2001 commented Apr 15, 2024

@FlorianWoelki I have tried what you asked. It did seem to partially solve the problem. Emojis are displayed now, but it's like it's using some older version of the emojis (I'm not sure how it works, I'm not really into this stuff). For example, instead of a farmer is displaying a person followed by a crop, which is not the emojis I used:

Schermata 2024-04-15 alle 21 27 18

It should show as 👩‍🌾, but it shows 👨🌾

@pyxelr
Copy link

pyxelr commented Apr 15, 2024

@FlorianWoelki: I also tried it.

Without Iconize:

without

With Iconize and modified main.js looks like more emojis have been displayed if you compare the screenshot from my previous comment. Notice, that when I hover my cursor over emoji, there is a magnifier button and a preview is being shown. The same magnifier is being shown when I hover over images, although then a preview is not shown:

with

@FlorianWoelki
Copy link
Owner

thank you for the feedback @Jaked2001 and @pyxelr

could you checkout this one. I was also able to reproduce the example by @pyxelr but with this version I am not able to reproduce it anymore.

fyi: the old link is broken.

@Jaked2001
Copy link
Author

Thank you for working on this right way trying to solve the issue.

I've just tried the last version you sent and it seems to be working as expected! All emojis are displaying the way they should.

Previus version:
Schermata 2024-04-15 alle 21 27 18

This version:
Schermata 2024-04-15 alle 21 54 09

@ShadyLX
Copy link

ShadyLX commented Apr 15, 2024

@FlorianWoelki Hey, I had the same problem as @Jaked2001, your newest main.js fixed it completely for me, thanks!
I'm new to the plugin and have a somewhat similar question though: When using icons from icon packs, for example :FabFonticonsFi: it is not rendered while the cursor is within the same paragraph of text, it renders only when the cursor is elsewhere, is this intended behavior? It's not a big deal, but I figured I asked anyway. :)

@FlorianWoelki
Copy link
Owner

really awesome to hear that! thanks for all the great collaboration on that issue! I'll try to release a new version in the next few days.

@FlorianWoelki Hey, I had the same problem as @Jaked2001, your newest main.js fixed it completely for me, thanks! I'm new to the plugin and have a somewhat similar question though: When using icons from icon packs, for example :FabFonticonsFi: it is not rendered while the cursor is within the same paragraph of text, it renders only when the cursor is elsewhere, is this intended behavior? It's not a big deal, but I figured I asked anyway. :)

yes, this is intended, but also a "bug". at least for now. I think, it is something similar to #315. feel free to upvote this one with a thumbs up.

@pyxelr
Copy link

pyxelr commented Apr 15, 2024

@FlorianWoelki: For me, it does not seem to be fixed with the new main.js. Everything is the same as in my last comment. I can still see the magnifier button upon hovering and the emoji style is different.

@FlorianWoelki
Copy link
Owner

@FlorianWoelki: For me, it does not seem to be fixed with the new main.js. Everything is the same as in my last comment. I can still see the magnifier button upon hovering and the emoji style is different.

yeah that's intended. sorry I was not aware of the magnifier there. but the tooltip always shows the "real" name of the emoji/icon. it's also described here.

@FlorianWoelki FlorianWoelki added bug Something isn't working and removed question Further information is requested labels Apr 15, 2024
@FlorianWoelki FlorianWoelki self-assigned this Apr 15, 2024
@FlorianWoelki FlorianWoelki moved this to Done in Iconize Board Apr 15, 2024
@rotane
Copy link

rotane commented Apr 15, 2024

could you checkout this one. I was also able to reproduce the example by @pyxelr but with this version I am not able to reproduce it anymore.

This does the trick for me as well. Thanks!

@FlorianWoelki
Copy link
Owner

the latest version v2.11.12 should fix this issue.

@FlorianWoelki FlorianWoelki moved this from Done to Deployed in Iconize Board Apr 17, 2024
@pyxelr
Copy link

pyxelr commented Apr 17, 2024

@FlorianWoelki: v2.11.12 still does not show up in my Obsidian community plugin updates (I have v2.11.11). Does it need to go through some verification process?

@FlorianWoelki
Copy link
Owner

@FlorianWoelki: v2.11.12 still does not show up in my Obsidian community plugin updates (I have v2.11.11). Does it need to go through some verification process?

normally, there is no verification process. I am also wondering why it is not updated. but, I cannot influence anything here.

@pyxelr
Copy link

pyxelr commented Apr 18, 2024

@FlorianWoelki: Ok, I finally managed to get an update.

I see that v2.11.12 partly resolved the issue.

Here is how it looks without Iconize (in live preview):

without

And here is how it looks with it:

with

When it is activated:

  • emojis look differently. I would prefer the look as in the 1st screenshot in this message
  • the 🏃‍♂️ (running_man) emoji is consisted of 2 emojis
  • emojis are highlighted and get a magnifier icon on top of them

Lastly, I noticed something (not sure if it is from this version) that when I change the "emoji style" in Iconize settings, I get this ℹ️ icon at the top of the page, which I can get rid of by reopening the page:

weird

@pyxelr
Copy link

pyxelr commented Apr 18, 2024

Ah, I noticed that 🏃‍♂️ (running_man) emoji is being consisted of 2 emojis, when:

  1. I turn off Iconize and have emoji shortcodes activated
  2. I add a 🏃‍♂️ (running_man) emoji and turn on Iconize.

Now I removed Emoji shortcodes plugin, as its functionality was being duplicated by Iconize.

Nevertheless, I also noticed quite a weird behaviour in live preview mode while using Iconize. Emojis change their look when I hit enter (when I hit backspace (or when I hit space on the same line), the original look is brought back):

Obsidian_2024-04-18_22-35-56

In "reading" mode they became brighter, while in "source mode" they look just like before hitting enter.

This seems to be fixed when I turn off "Toogle icons while editing notes", but I also lose the option to easily add emojis with :.

@FlorianWoelki
Copy link
Owner

Ah, I noticed that 🏃‍♂️ (running_man) emoji is being consisted of 2 emojis, when:

  1. I turn off Iconize and have emoji shortcodes activated
  2. I add a 🏃‍♂️ (running_man) emoji and turn on Iconize.

Now I removed Emoji shortcodes plugin, as its functionality was being duplicated by Iconize.

Nevertheless, I also noticed quite a weird behaviour in live preview mode while using Iconize. Emojis change their look when I hit enter (when I hit backspace (or when I hit space on the same line), the original look is brought back):

Obsidian_2024-04-18_22-35-56 Obsidian_2024-04-18_22-35-56

In "reading" mode they became brighter, while in "source mode" they look just like before hitting enter.

This seems to be fixed when I turn off "Toogle icons while editing notes", but I also lose the option to easily add emojis with :.

this is generally the live preview mode. whenever you enter the line, it will revert back to the original emoji/icon. that's why you also see the :CoFlag (for instance) instead of the rendered emoji when you are in the line.

@pyxelr
Copy link

pyxelr commented Apr 19, 2024

@FlorianWoelki: Thanks for explaining!

Well, to overcome this, I have installed emoji shortcodes and turned off "Toogle icons while editing notes" in Iconize settings. Otherwise, it was a little annoying to see the flashing emoji while editing text on the same line in live preview.

@FlorianWoelki
Copy link
Owner

@FlorianWoelki: Thanks for explaining!

Well, to overcome this, I have installed emoji shortcodes and turned off "Toogle icons while editing notes" in Iconize settings. Otherwise, it was a little annoying to see the flashing emoji while editing text on the same line in live preview.

lovely stuff, I'll try to fix this. could you create a new issue with the wonderful gifs you've provided? thanks!

@pyxelr
Copy link

pyxelr commented Apr 19, 2024

@FlorianWoelki: Thanks for explaining!
Well, to overcome this, I have installed emoji shortcodes and turned off "Toogle icons while editing notes" in Iconize settings. Otherwise, it was a little annoying to see the flashing emoji while editing text on the same line in live preview.

lovely stuff, I'll try to fix this. could you create a new issue with the wonderful gifs you've provided? thanks!

Sure! Here it is: #465.

I also created #466.

@jmonroynieto
Copy link

jmonroynieto commented Apr 20, 2024

I was using v2.11.12 (the latest available) and this problem is not resolved. You can see details of the issue on this forum post. I thought it was unrelated to plugins since the call stack for the line that modifies the emojis only contains app.js functions.

Disabling this plugin solved my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests