Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shutdown handling on Windows #79

Open
knolleary opened this issue May 5, 2023 · 0 comments
Open

Improve shutdown handling on Windows #79

knolleary opened this issue May 5, 2023 · 0 comments
Labels
task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@knolleary
Copy link
Member

Description

Originally raised in FlowFuse/nr-launcher#111 (review)

When running on Windows, the localfs driver issues:

childProcess.exec(`taskkill /pid ${projectSettings.pid} /T /F`)

Which essentially kills the process without ever performing a clean shutdown (so non of this code is ever executed by the launcher)

A possible future "fix" (also perhaps an improvement?) might be to utilise ipc or pipe and use process.send to tell the launcher to "shutdown" before any kill operation. This would permit a chance to verify the "shutdown" actually occurs and an opportunity to grab logs entries on the shutdown process.

Epic/Story

No response

@knolleary knolleary added the task A piece of work that isn't necessarily tied to a specific Epic or Story. label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Status: No status
Development

No branches or pull requests

1 participant