Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable=none should be added #1508

Open
Subnum12 opened this issue Nov 30, 2024 · 9 comments · May be fixed by #1511
Open

Clickable=none should be added #1508

Subnum12 opened this issue Nov 30, 2024 · 9 comments · May be fixed by #1511
Labels
feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do

Comments

@Subnum12
Copy link

Subnum12 commented Nov 30, 2024

Description

Any existing property "Clickable" I like to have an additional "none" option. This is essential to use e.g. a ui-switch as indicator.

grafik

Yes, there is a enabled option already. However, that behavior is differed as it not just disables control but also switches style to disabled/not available (grayed out).

You maybe consider this while fixing issue 662

@Subnum12 Subnum12 added feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do labels Nov 30, 2024
@bartbutenaers
Copy link
Contributor

@Subnum12
So that way you get a switch that will look like a normal switch, but you can't click it. Personally I would find that very confusing. But on the other hand I would never use that "None" option myself, so it would not bother me either that this new option is available there for users like you that like to have it that way.

I will try to find some time this evening to create a PR.

@colinl
Copy link
Contributor

colinl commented Nov 30, 2024

Would not something like the LED indicator be better for this?

@Tragl1968
Copy link

Tragl1968 commented Nov 30, 2024

I would appreciate the option "Clickable = None" in Dashboard 2.0 nodes, where applicable

  1. Clickable = None
    You may use everything that the dashboard node "switch" already can do
    AND you can use another icon, so it looks not like a switch but like a "sign"

versus

  1. LED Indicator
    You CANNOT use another icon, so you have only the LED itself.
    (Or someone has to pimp up the node "LED", so that custom icons are possible like in node "switch")

@bartbutenaers
Copy link
Contributor

The option is not making the config screen more complex, because it is hidden in a dropdown. And even if you open the dropdown, it is an extra option that makes sense between the other available options. So I don't think it will be of any harm to other users, which won't be using this new option.

@colinl
Copy link
Contributor

colinl commented Nov 30, 2024

An alternative, which would be more general, might be a new node type that displays one of a configurable set of icons, where the icon to display is determined by the incoming message.

@Subnum12
Copy link
Author

1. Clickable = None
   You may use everything that the dashboard node "switch" already can do
   AND you can use another icon, so it looks not like a switch but like a "sign"

Actual you describe my exact use case. I use switches with material design icons (e.g. door open/close, pump on/off).

advantages of "Clickable = None" would be

  • no impact on existing behavior/flows
  • less implementation work as will you have for a new node (less code required to be maintained)
  • a way more flexible as LED's. Icons often do not require description (open/close door icons speaks for it self - LED likely not)
  • personalty I prefer just a few high flexible nodes instead having a lot for just a single use-case .

@colinl I guess with 2 options (0/1) you can have it with ui-switch requested feature implementation for more options you maybe use ui-button-group .Of course that would require request Clickable option to be added here as well. (I'm using ui-button-group with material design icons for air-condition mode heat/cool/dry/off )

@bartbutenaers bartbutenaers linked a pull request Dec 1, 2024 that will close this issue
10 tasks
@bartbutenaers
Copy link
Contributor

Unfortunately I wasn't able to finalize my pull request, due to a CSS issue. I have asked on Discourse for assistance. Hopefully somebody jumps in to assist me...

@bartbutenaers
Copy link
Contributor

use ui-button-group .Of course that would require request Clickable option to be added here as well

Personally I don't like that idea. If you click on the label of a switch then you can toggle it. But if you click on the label of a button-group (with mire than 2 buttons) then the behaviour will become confusing.

@Subnum12
Copy link
Author

Subnum12 commented Dec 1, 2024

use ui-button-group .Of course that would require request Clickable option to be added here as well

Personally I don't like that idea. If you click on the label of a switch then you can toggle it. But if you click on the label of a button-group (with mire than 2 buttons) then the behaviour will become confusing.

Actually this FR is about indicator functionality "Clickable = None" so you not supposed to click anywhere.
Let me show you an example for previously mentioned air condition mode indicator:

grafik

However, using ui-button-group for control would be possible today already...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request that needs to be turned into Epic/Story details needs-triage Needs looking at to decide what to do
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants