-
Notifications
You must be signed in to change notification settings - Fork 1
feat: provide RHEL-compatible 10 and Debian trixie builds #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
custom/packaging/distros/almalinux/Dockerfile, line 107 (link)logic: Missing epel-release installation for AlmaLinux 10 base image unlike the ARM64 variant
9 files reviewed, 4 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
1a6b87f to
e14a3dc
Compare
Signed-off-by: Patrick Stephens <pat@fluent.do>
e14a3dc to
0506199
Compare
Signed-off-by: Patrick Stephens <pat@fluent.do>
e45874b to
21d852a
Compare
Signed-off-by: Patrick Stephens <pat@fluent.do>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14 files reviewed, no comments
Signed-off-by: Patrick Stephens <pat@fluent.do>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Signed-off-by: Patrick Stephens <pat@fluent.do>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
Integrates fluent/fluent-bit#10907 into our codebase.
Provides new targets for:
Also resolves issue with Rocky Linux images not being updated properly - see linked PR.
Ensure we build for mariner/2 now as well.
We have also reduced the set of targets for full releases to keep costs/time down:
PRs can still optionally build all possible targets via the appropriate labels, we have just reduced the targets for main/release builds.
Finally we make sure to set up authenticated pulls for DockerHub as this is not guaranteed on Namespace runners.
Greptile Overview
Updated On: 2025-10-05 13:20:07 UTC
Summary
This review covers only the changes made since the last review, not the entire PR. The current changes focus on implementing support for new RHEL-compatible distributions and Debian Trixie builds while streamlining the target matrix for cost optimization.The PR integrates upstream Fluent Bit changes to add support for several new Linux distributions: AlmaLinux 10, CentOS 10 Stream, Rocky Linux 10, and Debian Trixie. This expansion provides users with modern RHEL-compatible options and the latest Debian testing release. The changes follow established patterns in the codebase, creating both x86_64 and ARM64 variants for each new distribution to maintain architectural parity.
A key optimization introduced is the reduction of the full release target matrix to control build costs and time. The PR removes support for CentOS 8/9 Stream (due to upstream deviation and EOL status), older AlmaLinux versions (consolidating on Rocky Linux), and older Debian targets (keeping only the two latest). This streamlining affects only main/release builds, as PRs can still optionally build all targets via labels.
The implementation includes proper repository configuration for each distribution - enabling CRB repositories for YAML development libraries on RHEL-compatible distributions and ensuring EPEL package availability. ARM64 builds correctly include QEMU emulation and jemalloc optimizations for ARM64 architecture compatibility.
Additionally, the PR addresses a Rocky Linux image update issue and ensures Mariner/2 builds are included. GitHub workflow changes improve release note formatting by clearly separating Windows and Linux targets, and authenticated DockerHub pulls are configured for Namespace runners.
PR Description Notes:
Important Files Changed
Changed Files
source/packaging/distros/almalinux/Dockerfilecustom/packaging/distros/almalinux/DockerfileConfidence score: 4/5