Skip to content

Conversation

@patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Oct 3, 2025

Integrates fluent/fluent-bit#10907 into our codebase.

Provides new targets for:

  • alma linux 10
  • centos 10 stream
  • rocky linux 10
  • debian trixie

Also resolves issue with Rocky Linux images not being updated properly - see linked PR.

Ensure we build for mariner/2 now as well.

We have also reduced the set of targets for full releases to keep costs/time down:

  • Remove CentOS 8/9 stream - upstream deviates a lot or is EOL anyway, use Rocky Linux
  • Remove AlmaLinux - use Rocky Linux instead
  • Remove older Debian targets so only two latest are included

PRs can still optionally build all possible targets via the appropriate labels, we have just reduced the targets for main/release builds.

Finally we make sure to set up authenticated pulls for DockerHub as this is not guaranteed on Namespace runners.

Greptile Overview

Updated On: 2025-10-05 13:20:07 UTC

Summary

This review covers only the changes made since the last review, not the entire PR. The current changes focus on implementing support for new RHEL-compatible distributions and Debian Trixie builds while streamlining the target matrix for cost optimization.

The PR integrates upstream Fluent Bit changes to add support for several new Linux distributions: AlmaLinux 10, CentOS 10 Stream, Rocky Linux 10, and Debian Trixie. This expansion provides users with modern RHEL-compatible options and the latest Debian testing release. The changes follow established patterns in the codebase, creating both x86_64 and ARM64 variants for each new distribution to maintain architectural parity.

A key optimization introduced is the reduction of the full release target matrix to control build costs and time. The PR removes support for CentOS 8/9 Stream (due to upstream deviation and EOL status), older AlmaLinux versions (consolidating on Rocky Linux), and older Debian targets (keeping only the two latest). This streamlining affects only main/release builds, as PRs can still optionally build all targets via labels.

The implementation includes proper repository configuration for each distribution - enabling CRB repositories for YAML development libraries on RHEL-compatible distributions and ensuring EPEL package availability. ARM64 builds correctly include QEMU emulation and jemalloc optimizations for ARM64 architecture compatibility.

Additionally, the PR addresses a Rocky Linux image update issue and ensures Mariner/2 builds are included. GitHub workflow changes improve release note formatting by clearly separating Windows and Linux targets, and authenticated DockerHub pulls are configured for Namespace runners.

PR Description Notes:

  • The PR description contains a minor formatting inconsistency with "alma linux" instead of "AlmaLinux" in the bullet point list

Important Files Changed

Changed Files
Filename Score Overview
source/packaging/distros/almalinux/Dockerfile 4/5 Added AlmaLinux 10 support with x86_64 and ARM64 base images following established patterns
custom/packaging/distros/almalinux/Dockerfile 4/5 Added AlmaLinux 10 build stages with proper EPEL package installation and ARM64 support

Confidence score: 4/5

  • This PR is safe to merge with low risk as it follows established patterns and adds support for new distributions
  • Score reflects well-structured changes that maintain consistency with existing build patterns, though some complexity exists in multi-architecture Docker builds
  • The AlmaLinux Dockerfile changes have been addressed from previous reviews and now include proper EPEL package installation

@patrick-stephens patrick-stephens requested a review from a team as a code owner October 3, 2025 15:12
@patrick-stephens patrick-stephens added the build-linux Option to enable building of Linux packages only for a PR to test label Oct 3, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. custom/packaging/distros/almalinux/Dockerfile, line 107 (link)

    logic: Missing epel-release installation for AlmaLinux 10 base image unlike the ARM64 variant

9 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@patrick-stephens patrick-stephens marked this pull request as draft October 3, 2025 15:24
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens patrick-stephens removed the build-linux Option to enable building of Linux packages only for a PR to test label Oct 5, 2025
Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens patrick-stephens changed the title feat: enable RHEL-compatible 10 builds and Debian trixie from upstream feat: provide RHEL-compatible 10 and Debian trixie builds Oct 5, 2025
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens patrick-stephens marked this pull request as ready for review October 5, 2025 11:51
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@patrick-stephens patrick-stephens marked this pull request as draft October 5, 2025 11:54
Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens patrick-stephens added the build-linux Option to enable building of Linux packages only for a PR to test label Oct 5, 2025
@patrick-stephens patrick-stephens marked this pull request as ready for review October 5, 2025 11:55
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Signed-off-by: Patrick Stephens <pat@fluent.do>
@patrick-stephens patrick-stephens removed the build-linux Option to enable building of Linux packages only for a PR to test label Oct 5, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@patrick-stephens patrick-stephens merged commit 755b8e1 into main Oct 5, 2025
50 of 62 checks passed
@patrick-stephens patrick-stephens deleted the update_pr10907 branch October 5, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants