Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFFECT_CHANGE_DAMAGE should be taken in account when calculating battle damage #323

Open
edo9300 opened this issue Jun 21, 2020 · 1 comment

Comments

@edo9300
Copy link
Contributor

edo9300 commented Jun 21, 2020

If a card like Dark Ruler no More change all the damage to 0, it will also set the battle damage to 0, so in field::calculate_battle_damage when the various EFFECT_CHANGE_BATTLE_DAMAGE are checked, any EFFECT_CHANGE_DAMAGE that is also valid for battle damage should be taken in consideration, otherwise while attacking under the 0 damage of dark ruler no more, Duel.GetBattleDamage will return a non 0 value, even if that attack will deal no damage. @DailyShana

@salix5
Copy link
Collaborator

salix5 commented Jun 27, 2020

It was a misclick.
#324 did not fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants