Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent cont trap refactor breaks Royal Opression #2363

Open
Ejeffers1239 opened this issue Jan 17, 2024 · 2 comments
Open

Recent cont trap refactor breaks Royal Opression #2363

Ejeffers1239 opened this issue Jan 17, 2024 · 2 comments

Comments

@Ejeffers1239
Copy link
Contributor

Ejeffers1239 commented Jan 17, 2024

Royal Oppression is nonfunctional on production with error message "Parameter 2 should be 'Function'."

0b7ea09

The change in the above commit is likely what broke it. I may try to fix it myself but it's been ages since I scripted and Royal Oppression is a relatively ancient and weird card. If it's something simple I can probably get it done. [Edit: Nope, the script is too complicated because of the either player SS3, I cannot fix this myself without a lot of pain. I also don't know what the above commit was intending to fix so I don't know if reverting is a good option or not.]

@Ejeffers1239
Copy link
Contributor Author

Ejeffers1239 commented Jan 17, 2024

Add: Koishipro reports the error as on line 15, the aux.NegateSummonCondition line.
Was the aux function changed? The old functioning script does not use this aux function so it may be incorrect to use since Royal Opp's activation condition is fairly strange.

@mercury233
Copy link
Collaborator

You will have to make sure you are using both latest ocgcore and card scripts and utility.lua and so on
For this problem you hadn't updated #2299 so you don't have cc66947#diff-464c93be6429bb4208dac585c43ce7e1992c1bdcefcdc63c0a4ceb0565c94c92R1475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants